I just upgraded my Javascript Tools to 5.x-0.2 and was testing my test site in both firefox and IE. It works fine in firefox, but on reload of IE I get this error

Fatal error: Call to undefined function: jstools_modules_includes() in .... (my site address).../sites/all/modules/jstools/activemenu/activemenu.module on line 50

It only begins after I try to visit my site the second time and then onwards with IE.

If it helps, my testsite www.pemberworth.com/drupal

CommentFileSizeAuthor
#2 error message.png4.84 KBdrupalluver

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Hmm, this is a new function in this relase but I'v confirmed it's there in the jstools.module code. Maybe this error has to do somehow with page caching?

drupalluver’s picture

drupalluver commented
StatusFileSize
new error message.png4.84 KB

I am not very knowledgeable about some of this. I have included a snapshot as I'm going to try to change my version of jstools to remove the error.

By the way, I have now had a friend visit the test site in both IE and FF and she gets the error message with both.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Title: Jstools does not work in IE but works in Firefox » Call to undefined function jstools_modules_includes()

I'd incorrectly put the jstools_modules_includes() in a hook_init() function. I've moved it to hook_menu(), where it should be safe from caching errors.

Applied to trunk. I'll need to merge with the 5.0 branch. Then, I guess, post a new release.

drupalluver’s picture

drupalluver commented

Thanks!

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Fixed

I've posted a new release with the fix.

robertgarrigos’s picture

robertgarrigos commented
Status: Fixed » Active

sorry, but your 5.x branched files are older than your 5.x.0-3 release, and those are the ones you download when using "cvs -r DRUPAL-5". could you update the 5.x branched code with this bug fixing? thanks

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks for the note, indeed I'd forgotten to merge some files into the 5.0 branch, but had merged others, producing this bug.

I've now merged them but need to do more testing, tomorrow.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Version: 5.x-0.2 » 5.x-1.x-dev
Status: Active » Fixed

The fix appears to have worked. Applied to the 5.x branch. Book support should work in the next 'official release' of jstools. Meantime you can use the 5.x dev download, http://drupal.org/node/113162.

And, yes, please reopen this issue if that dev version is still generating the error.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)