Translatable fields might have the need to share the values of some field columns, for instance a file field might have a textual description which need to be translated while the fid itself should be shared among the field translations.

A possibile solution to this need could be introducing synchronization at field column level. On the translation UI we could only introduce a warning that changing the field value would trigger a change into all the field translations. We could then have a field set in the field settings form allowing to choose which solumn need to be synchronized.

Comments

vasike’s picture

subscribe

plach’s picture

plach’s picture

Component: Code » Base system
Status: Active » Needs review
StatusFileSize
new5.51 KB

Here is a patch. It provides column synchronization for file and image fields. To test it apply the patch, clear the caches and enable field synchronization in field settings.

Status: Needs review » Needs work

The last submitted patch, et-1133038-3.patch, failed testing.

plach’s picture

Status: Needs work » Needs review
StatusFileSize
new5.29 KB

This one should work.

plach’s picture

StatusFileSize
new6.28 KB

Better one: now elements may be freely reordered without triggering synchronization. I think this is ready to go. Please confirm.

plach’s picture

StatusFileSize
new6.52 KB

Small enhancement.

plach’s picture

StatusFileSize
new7.38 KB

Fixed a couple of edge cases.

Status: Needs review » Needs work
Issue tags: -D7 stable release blocker

The last submitted patch, et-1133038-8.patch, failed testing.

plach’s picture

Status: Needs work » Needs review

#8: et-1133038-8.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +D7 stable release blocker

The last submitted patch, et-1133038-8.patch, failed testing.

plach’s picture

Status: Needs work » Needs review

Right, this has been rolled against the ml_edit_form branch.

plach’s picture

Status: Needs review » Postponed

Also this one is waiting for #1495648: Introduce entity language support.

plach’s picture

StatusFileSize
new7.33 KB

This works even with non existing field translations.

plach’s picture

Issue tags: +Needs tests

Totally needs test coverage.

plach’s picture

Status: Postponed » Needs review

Going to commit soon.

plach’s picture

Status: Needs review » Fixed

Committed and pushed.

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 88ae224 on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions by plach:
    Issue #1133038 by plach: Added support for field column synchronization.
    

  • Commit 88ae224 on 7.x-1.x, et-permissions-1829630, factory, et-fc, revisions, workbench by plach:
    Issue #1133038 by plach: Added support for field column synchronization.