shouldnt this be changed:

function password_policy_update_6002() {
  $ret = array();
  db_change_field(&$ret, 'password_policy', 'policy', 'policy', array(
    'description' => t('The serialized policy data'),
    'type' => 'varchar',
    'length' => 1024,
    'not null' => TRUE,
    'default' => '',
  ));
  return $ret;
}

to

function password_policy_update_6002() {
  $ret = array();
  db_change_field($ret, 'password_policy', 'policy', 'policy', array(
    'description' => t('The serialized policy data'),
    'type' => 'varchar',
    'length' => 1024,
    'not null' => TRUE,
    'default' => '',
  ));
  return $ret;
}
CommentFileSizeAuthor
#8 warning-1133216_8.patch743 bytessubson

Comments

letzel’s picture

letzel commented
Version: 6.x-1.x-dev » 6.x-1.0

The above warning appears during the update process from 6.x.1.0-beta1 to 6.x.1.0, and it effectively prevents my from doing the update. So I need to stick with beta1 for the moment.

sterndata’s picture

sterndata commented

subscribe

joeebel’s picture

joeebel commented

subscribe

Archnemysis’s picture

Archnemysis commented

After removing the ampersand from the install file as suggested, I then un-installed and re-installed password policy without any problems.

dakku’s picture

dakku commented

Thank you for your confirmation!

Can this be added into the next commit guys?

John Carbone’s picture

John Carbone commented

Just an FYI: Warnings are also shown when enabling, disabling or updating any module via drush with password policy turned on.

[Edit] This was causing updates from other modules to fail completely, either at update.php or via drush. Removed the '&' and all appears well.

threexk’s picture

threexk commented
Status: Patch (to be ported) » Reviewed & tested by the community

I think the status here is incorrect; there is no patch that needs to be ported. Moving to RTBC because I don't think it's necessary to roll and test a patch for such a minor change.

subson’s picture

subson commented
Status: Reviewed & tested by the community » Patch (to be ported)
StatusFileSize
new warning-1133216_8.patch743 bytes

Adding a patch for next release.

erikwebb’s picture

erikwebb commented
Version: 6.x-1.0 » 6.x-1.x-dev
Assigned: Unassigned » erikwebb
Status: Patch (to be ported) » Fixed

Fixed and committed!

http://drupalcode.org/project/password_policy.git/commit/e419ad9

@subson - FYI, when submitting future patches, please create patch files from within the module directory.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.