Once the HEAD version is tested and such, a 5.x release should be created for it. I wouldn't bother with "official" releases, but a dev release would ensure that it shows up in the list of 5.x compatible modules.

While HEAD is still in flux, though, doesn't make a lot of sense to branch it -- once that's done, fixes need to be committed twice.

CommentFileSizeAuthor
#1 module_builder.module.patch687 bytesShiny

Comments

Shiny’s picture

Status: Active » Needs review
StatusFileSize
new687 bytes

feedback:

under php 4.4.2-1.1 (debian stable), the module fatals on pressing "download module"
Fatal error: Call to undefined function: stripos() in /home/brenda/projects/drupal/contributions/modules/module_builder/module_builder.module on line 286

i'm not sure of drupal policy for support of php4, but until debian stable moves i must stick with php4.
I've attached a patch that adds the following:

<?php
//Helper function, for php4
if (!function_exists('stripos')) {
	function stripos($string,$word){
		$retval = false;
		for($i=0;$i<=strlen($string);$i++) {
			if (strtolower(substr($string,$i,strlen($word))) == strtolower($word)) {
				$retval = true;
			}
		}
		return $retval;
	}
}
?>

README.txt:
* Fieldsets in Opera look mondo bizarr-o

I tested in Opera (9.02-20060919.6) on ubuntu amd64 - display pretty much the same as in firefox (2.0.0.2+0dfsg-0ubuntu0.6.10).

nancydru’s picture

Wouldn't this be quicker:

if (!function_exists("stripos")) {
  function stripos($str, $needle, $offset=0)
  {
      return strpos(strtolower($str), strtolower($needle), $offset);
  }
}
ray007’s picture

subscribing

nancydru’s picture

What's the status on this?

robloach’s picture

Title: Create 5.x release » Make module_builder 5,x work in PHP4
Version: » 5.x-1.x-dev
Priority: Normal » Minor

The development snapshot is now out, hoping to see some issues pop up. Changing the title to having to do with PHP4, as it seems this is what's being discussed here.

joachim’s picture

Status: Needs review » Closed (fixed)

Closing this as surely now everyone has PHP5 at least on their development system.