Posted by Zen on January 27, 2007 at 8:46pm
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | taxonomy.module |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Zen |
| Status: | needs work |
Issue Summary
Similar to the node management page, I believe that terms should also be manageable. The patch:
- Adds select all/ checkbox support to the page.
- Adds an operations field similar to the node management page. Other modules can hook in (untested) etc.
- Uses a multi-step form instead of callbacks. This should enable more complex functionality by contrib modules.
- Currently only offers a mass delete option in core.
This was created and tested against 1.331 and merged with HEAD.
First time I'm playing with multi-step forms, and I'm sure that this can be improved.
Reviews welcome.
Cheers,
-K.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| taxonomy-management-3.patch | 8.1 KB | Ignored: Check issue status. | None | None |
Comments
#1
I don't know how the 'map arguments' field is supposed to be set.
#2
This is a *really* great idea. I will review the patch later when I have some more time.
#3
*subscribing* to test out later once HEAD is settled down a bit and the dust fell down..
#4
I think this is a good idea. Care to share some screenshots? :)
I'd love to see something for paths too.
Plus, I'd love other modules to be able to tap into these operation boxes and add some of their own. I think we need to take a step back, and come up with a system that provides that.
#5
Yes, other modules can tap into this form. I've cleaned the patch up a little further and also added an example module as a demo of how other modules can hook into this. The screen looks just like the node manager screen.
In the interest of easy reviewing, I've created the patch against Drupal HEAD as of Jan 24 0000 UTC. Consequently, please checkout using the -D switch (something like -D "2007-1-24 05:30" [accounting for my zone offset]).
Thanks
-K
#6
Sync with HEAD + some tidying up.
-K
#7
And here's the demo module.
#8
Another Sync patch.
#9
Zen care to share some screenshots?
#10
I like this patch a lot; however, portions of it no longer apply cleanly to HEAD.
# patch -p0 < tax-multi-step_0.patch
(Stripping trailing CRs from patch.)
patching file modules/taxonomy/taxonomy.module
Hunk #2 FAILED at 134.
1 out of 3 hunks FAILED -- saving rejects to file modules/taxonomy/taxonomy.module.rej
#11
Should be re-assessed now this is available: http://drupal.org/project/taxonomy_manager
#12