Posted by J. Cohen on April 21, 2011 at 1:21am
6 followers
Jump to:
| Project: | Gravatar integration |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | Narno |
| Status: | needs review |
Issue Summary
When I upgraded Author Pane and Advanced Forum last night, Gravatar stopped working. I posted in the Author Pane section, but they were under the impression that Gravatar didn't integrate with Author Pane, and that it is a Gravatar issue.
I just upgraded Gravatar to gravatar 6.x-1.x-dev, but the issue is still there.
Example:
http://mnemotechnics.org/x/forums/weekly-memory-challenges-and-3-month-l...
Is it an issue with Gravatar?
Comments
#1
Anyone fixed this issue ?
#2
Adding this line in author_pane-6.x-2.2 temporarily fix the problem
diff --git a/sites/default/modules/author_pane/author_pane.module b/sites/default/modules/author_pane/author_pane.module
--- a/sites/default/modules/author_pane/author_pane.module
+++ b/sites/default/modules/author_pane/author_pane.module
@@ -183,6 +183,8 @@
$preset = (!empty($variables['picture_preset'])) ? $variables['picture_preset'] : '';
$variables['picture'] = theme('author_pane_user_picture', $variables['account'], $caller, $preset);
$user_pictures[$account_id] = $variables['picture'];
+// force integration with gravatar
+ $variables['picture'] = theme('user_picture', $account);
}
/* Join date & online status */
I think that for a right integration, a new modules/author_pane/modules/gravatar.author-pane.inc is needed.
#3
#4
Author Pane isn't going to be adding code on behalf of other modules anymore. Twice now we've run into security issues because of it. If Gravatar wants to integrate, they can host their own preprocess code.
Michelle
#5
Tanks for feedback Michelle!
Guys, I'm waiting for a "gravatar_preprocess_author_pane(&$variables)" patch :-)
#6
I'm a little curious why author_pane isn't using the standard theme_user_picture()?
#7
@Dave: Because it doesn't make sense to link to the profile page from the profile page and because clicking the avatar to see the larger version in forums always made more sense to me than having clicking the avatar take you to the same place that clicking the name does.
Michelle
#8
#9
Author Pane module support added in 6.x-1.x-dev version. More details: http://drupalcode.org/project/gravatar.git/blob/refs/heads/6.x-1.x:/grav...