This is a continuation of: http://drupal.org/node/1128960#comment-4374342

Why I didn't patch the original style bases:

  • The original Rounded Corners functions performed additional processing; changing this might have negative impacts on current sites.
  • Additional palette settings were created; changing this could negatively impact current sites.

Patch files for region_css3 and pane_css3 to be posted promptly.

CommentFileSizeAuthor
#1 1134092-panels-add-css3-style-bases-pane_css3.patch8.24 KBwjaspers
#1 1134092-panels-add-css3-style-bases-region_css3.patch7.76 KBwjaspers

Comments

wjaspers’s picture

wjaspers commented
StatusFileSize
new 1134092-panels-add-css3-style-bases-region_css3.patch7.76 KB
new 1134092-panels-add-css3-style-bases-pane_css3.patch8.24 KB
wjaspers’s picture

wjaspers commented
Status: Active » Needs review
jastraat’s picture

jastraat commented

Note: I'm using a copy of the latest -dev of both panels and ctools with the 3 patches related to this issue from ctools and panels.

Get the following error when trying to use the CSS3 Region style:

* Notice: Undefined index: border in panels_region_css3_style_settings() (line 70 of /public_html/sites/all/modules/panels/plugins/style_bases/region/region_css3/region_css3.inc).
* Notice: Undefined index: text_font in panels_region_css3_style_settings() (line 73 of /public_html/sites/all/modules/panels/plugins/style_bases/region/region_css3/region_css3.inc).
* Notice: Undefined index: box_shadow in panels_region_css3_style_settings() (line 79 of /public_html/sites/all/modules/panels/plugins/style_bases/region/region_css3/region_css3.inc).
* Notice: Undefined index: transform in panels_region_css3_style_settings() (line 82 of /public_html/sites/all/modules/panels/plugins/style_bases/region/region_css3/region_css3.inc).
* Notice: Undefined index: opacity in panels_region_css3_style_settings() (line 85 of /public_html/sites/all/modules/panels/plugins/style_bases/region/region_css3/region_css3.inc).
* Notice: Undefined index: columns in panels_region_css3_style_settings() (line 88 of /public_html/sites/all/modules/panels/plugins/style_bases/region/region_css3/region_css3.inc).
* Notice: Undefined index: text_shadow in panels_region_css3_style_settings() (line 91 of /public_html/sites/all/modules/panels/plugins/style_bases/region/region_css3/region_css3.inc).
* Notice: Undefined index: box_resize in panels_region_css3_style_settings() (line 94 of /public_html/sites/all/modules/panels/plugins/style_bases/region/region_css3/region_css3.inc).

Also get an error when attempting to use the CSS3 Rounded Box style for panel panes:

* Notice: Undefined index: box_shadow in panels_pane_css3_style_settings() (line 89 of/public_html/sites/all/modules/panels/plugins/style_bases/pane/pane_css3/pane_css3.inc).
* Notice: Undefined index: transform in panels_pane_css3_style_settings() (line 92 of /public_html/sites/all/modules/panels/plugins/style_bases/pane/pane_css3/pane_css3.inc).
* Notice: Undefined index: opacity in panels_pane_css3_style_settings() (line 95 of /public_html/sites/all/modules/panels/plugins/style_bases/pane/pane_css3/pane_css3.inc).
* Notice: Undefined index: columns in panels_pane_css3_style_settings() (line 98 of /public_html/sites/all/modules/panels/plugins/style_bases/pane/pane_css3/pane_css3.inc).
* Notice: Undefined index: text_shadow in panels_pane_css3_style_settings() (line 101 of /public_html/sites/all/modules/panels/plugins/style_bases/pane/pane_css3/pane_css3.inc).
* Notice: Undefined index: box_resize in panels_pane_css3_style_settings() (line 104 of /public_html/sites/all/modules/panels/plugins/style_bases/pane/pane_css3/pane_css3.inc).

lsolesen’s picture

lsolesen commented

What is the state of this style base?

wjaspers’s picture

wjaspers commented
Status: Needs review » Needs work

Will re-build this patch sometime this week/weekend.

lsolesen’s picture

lsolesen commented

You ever gotten around to rebuild the patch?

wjaspers’s picture

wjaspers commented

Wow; looking back at my prior patch(es) on this....Blech.

I also noticed that this patch is entirely dependent on stylizer options that I tried to introduce by hacking the hell out of it, rather than altering the stylizer form. Such is the learning curve of Drupal.
In further thought about how this works, a solid theme will be able to accomplish the necessary things by not even using the stylizer--however, that is not to say these options are useless--they're more useful to someone with less themeing capability.

With that said, I can either a) introduce a patch that makes these style bases available in panels (and create a new patch for the stylizer and wait for it be accepted/rolled-in), or b) turn it into a contrib module (and attach the stylizer functionality via a form alter).

japerry’s picture

japerry
Location KOMK
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.