the ampm stuff in timestamp.inc is screwy because it was copied pretty much directly from event.module and there is an ampm variable specific to event.module that has not been copied over.
also, there is a bug in that ampm code that was recently fixed in event.module that has not yet been fixed in flexinode.module.
the bug in event.module that was fixed is here: http://cvs.drupal.org/viewcvs/contributions/modules/event/event.module?r...
this first patch is to field_timestamp.inc and it applies the changes that fixed the bug in event module and also gets the file ready to read the flexinode_ampm variable that will be implemented in flexinode.module at some point (that is... if no core solution emerges). this changes all instances of event_ampm to flexinode_ampm.
ensuing patches will be to add this variable to the database and create the am/pm on/off setting on the flexinode admin page.
erik.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | flexinode_ampm_timestamp_inc_0.patch | 2.42 KB | erikhopp |
| flexinode_ampm_timestamp_inc.patch | 1.81 KB | erikhopp |
Comments
Comment #1
erikhopp commentedhuh. well, that was much easier than i thought it was going to be.
this patch includes all the changes of the last one, plus the additional setting in the flexinode settings copied from event module.
that should be everything for this bug.
this patch supercedes the first one.
Comment #2
Bèr Kessels commentedCan someone please test this patch?
Comment #3
samc commentedThis is still a valid issue. I was just wondering what the event stuff was all about.
The fix looks solid, but the form code in this patch is for 4.6. Will need to be updated and rerolled.
Is the assignment to erikhopp still valid??
Comment #4
erikhopp commentedanyone can feel free to move forward with this. i don't have time to reroll it...
its pretty simple though.