In logintoboggan.module, the error text "Access denied.  You may need to login below or register to access this page." has two spaces between the sentences. This is problematic, as 1) it can be confusing to users trying to use string overrides to change it since the double space is not displayed when the string is displayed in the browser, 2) it's bad form.

In the following patch, I propose removing the space to avoid confusion and make the gods of typography happy.

Thanks for your consideration.

CommentFileSizeAuthor
#3 logintoboggan-6.x-error-spacing-1135870.patch11.44 KBfroboy
#3 logintoboggan-7.x-error-spacing-1135870.patch10.42 KBfroboy
#1 logintoboggan-error-spacing-1135870.patch607 bytesfroboy

Comments

froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
commented
StatusFileSize
new logintoboggan-error-spacing-1135870.patch607 bytes

Patch attached.

hunmonk’s picture

hunmonk commented
Status: Needs review » Needs work

i read over a few articles on the subject, and i agree that we should switch to a single space after a period. however, i will not accept the patch in its current format. this should be a module-wide fix, so i'll need two patches (one for 6.x and one for 7.x) which correct all instances of this issue in all files.

froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
commented
Status: Needs work » Needs review
StatusFileSize
new logintoboggan-7.x-error-spacing-1135870.patch10.42 KB
new logintoboggan-6.x-error-spacing-1135870.patch11.44 KB

Thanks. I think these should take care of them all...

hunmonk’s picture

hunmonk commented
Title: Access denied string spacing is confusing » Use single spacing between sentences
Status: Needs review » Fixed

committed to 6.x-1.x-dev and 7.x-1.x-dev, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.