CommentFileSizeAuthor
#6 1136052_tidy.patch1.04 KBsylvain lecoy
#1 1136052_tidy.patch1.6 KBsylvain lecoy

Comments

sylvain lecoy’s picture

sylvain lecoy commented
Status: Active » Needs review
StatusFileSize
new 1136052_tidy.patch1.6 KB

See attached patch

marcingy’s picture

marcingy commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, none of the files being removed have classes to dynamically load.

sylvain lecoy’s picture

sylvain lecoy commented

Hang on, it actually introduce a bad situation where all test related files are not seen anymore by the SimpleTest framework.

kylebrowning’s picture

kylebrowning commented

yeah this is required by SimpleTest unfortunately

kylebrowning’s picture

kylebrowning commented
Status: Reviewed & tested by the community » Needs work
sylvain lecoy’s picture

sylvain lecoy commented
StatusFileSize
new 1136052_tidy.patch1.04 KB

Here it is

kylebrowning’s picture

kylebrowning commented

Why is services.runtime.inc not removed but everything else is?

sylvain lecoy’s picture

sylvain lecoy commented

services.runtime.inc is the only file containing classes so to load them up without including files we need to tell drupal registry to lookup in there.

kylebrowning’s picture

kylebrowning commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.