If buddylist is empty, show a message in the buddy-block

Hi AstraIP, thanks for your lean approach that will fit perfectly your special needs. :)

Explore my patch as it might be more configurable for you. Changes are explained above. And I realize it's working well and stable on my site. Please give a note if the patch is accepted for I'm working on further buddylist enhancements. Buddylist is a real cool module having an exciting future!
More ideas shared next time. ;)

Hi AstraIP, the "My buddy list" block always shows the buddies of the current user. Why do you want to check for "edit access"? Please explain... Usually every user can change his own buddylist - it would be evil to make fun of him without offering the chance to change.

It would make sense in two ways:

• A text given to anonymous users (I don't see a reason to distinct)
• Any users if we would have a block that shows "Someone's buddy list" aside a user's (profile) page. I'm strongly in favour of this! :D Who writes this?????

Until then the code would do. I'll post it here to give an overview:

function buddylist_block($op = 'list', $delta = 0) {
  global $user;

  // some code

    switch ($delta) {
      case 0 : // Shows buddylist block
        if ($buddies = buddylist_get_buddies()) {
          // we have buddies defined and generate the list
          $i = 0;
          foreach (array_keys($buddies) as $buddy) {
            $users[] = user_load(array('uid' => $buddy));
            $i++;
            if ($i == variable_get('buddylist_blocklisting_size', 5)) {
              break;
            }
          }
          $block['content'] = theme('user_list', $users);
        } else {
          // buddylist is empty
          if (variable_get('buddylist_block_if_no_buddies', FALSE)) {
            // Show a message that we have no buddies yet
            $block['content'] = t(variable_get('buddylist_empty_text', ''), buddylist_translation());
          } else {
            // If no buddies defined and no message wanted, end 'case' without returning block.
            break;
          }
        }
        // this is the same output whether buddylist or not
        $block['subject'] = variable_get('buddylist_list_block_title', t('My @buddy list', buddylist_translation()));

        // check if a "more" link should generated by seeing if there are more buddies than the specified $upperlimit
        if (count($buddies) > variable_get('buddylist_blocklisting_size', 5)) {
            $block['content'] .=  '<div class="more-link">' . l(t('more'), 'buddylist', array('title' => t('View more.'))) . '</div>';
        }
        return $block;
      break;
  // other code
}

Hi! Thanks for the nice talk that kept my brain active!
@AstraIP: This block you intended to change would be ***very*** appreciated! I would like to collaborate, if you have a suggestion! :)

@robertDouglass: I'm not so familiar with diff and patch, yet. I hope this patch will do (otherwise please tell me). Generated it with diff -up from the current cvs.
This was not easy because - as I said before - I'm working on further changes for the buddylist.module and had to copy&paste everything again. I agree in dividing each patch an issue, but this seems to be so slow. So, I would like to work with cvs instead to parallize improvements. Even though my practical experience is at a beginning state I know enough about the advantages to be willing to learn it!

@ robertDouglass: Thank you very much for your explainations! :)
I promise I will dive into CVS! Instead of eclipse: Had some warm-up with command-line cvs. And last weeks, Zend became a new friend of mine, maybe I can convince him doing those CVS stuff for me ;)

Regarding the patch: I'm not sure about the nesting of the t() functions. Please have a closer look onto it, because I could not test it.
How do I create a new template file for translation? I'd love to work on a new german translation because I need this for my own project (just using Drupal's string search is not sophisticated enough)

Thanks for your help, fago, I made the changes as you said. This was quite easy with your explainations and went really fast.

But: Creating a patch is getting harder each time as I went forward doing some little improvements here and there without having a well arranged working environment, yet. Robert gave some nice hints that go in the right direction, I totally agree with that, but I could not aplly them because I work with another environment and started working on other issues already. Although I just use one buddylist.module file in my webserver's directory I now have dozens of .orig .cvs .new files and some more .2007-02-11-files now in some different directories that really made me mad today. I would really like to know how this could be made simplier. I would really like to give back my improvements to you and I understand the necessarity of breaking changes into issues and reviewing each issue, but I cannot spend some days just for bringing in one patch. Any suggestions are welcome on that.

I think this one is done.

Ok, next time! ;)

As I just noticed, the t() nesting is not working this way I did it now.

Anyone?

Sorry, I should explain: @buddy is not substituted anymore.
I'm out of time for today, I pick this up some days later if it's still active.

Ok, the error I noticed yesterday was no error, it was a special effect inducted from the database-entries I already had before the changes.

Anyway I've made a one-char-improvement compared to the yesterday-patch, that was it worth! :)

Besides, this time I did the patch using cvs diff instead of diff. The diff was made against the HEAD version. This was pretty fast and easy!

Just patched it, great improvements, thank you joshk!
As you will have been noticed, I'm no native speaker, so these improvements are very welcome.

It's REALLY to much of honor to let ME decide to check in... but alright: "ENERGY!"