Looks great, nice and simple. Will try implementing and give feedback.

CommentFileSizeAuthor
#1 codecleanup-1136738-1.patch6.43 KBtanc

Comments

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented
Status: Active » Needs review
StatusFileSize
new codecleanup-1136738-1.patch6.43 KB

I've just finished testing and I think this module is excellent. It does what it sets out to do very nicely. I've attached a simple code cleanup patch, nothing major in there, just some comment blocks added and spacing removed. The js file wasn't being included so I deleted it and added the js inline.

I'd like to see a release of this module and some more feedback from the community.

One question, why did you choose to create a new table to store comments in rather than the Drupal comments table? The only reason I ask is because if a site admin chooses to migrate back to Drupal based comments they'll have to migrate from disqus_backup table to the comments table.

Haehnchen’s picture

Haehnchen commented

thx. put comments back to drupal core would be nice. but i see some hard parts:

-need a good solution, to find comments that already imported (disqus id != drupal id)
-tree handling of comments

because i want a fast way to get my comments back i on page to moved them out of drupal.

i will commit your patch by time...

Haehnchen’s picture

Haehnchen commented
Status: Needs review » Reviewed & tested by the community