Steps to reproduce:
1) Change line endings to CRLF in a .module file
2) Insert trailing white space at the end of a line
3) Ensure settings will pick up minor errors
4) Perform a code review on the relevant module

Expected result:
- coder complains about the fact that CRLF is being used instead of LF
- coder complains about the trailing white space

Actual result:
- coder does not report the trailing white space or CRLF issues
- if there were no other errors in the file then coder reports that there were no issues found

Comments

douggreen’s picture

douggreen commented
Version: 7.x-1.0-beta6 » 7.x-2.x-dev
mikeker’s picture

mikeker commented

For what it's worth, then I had accidentally set Git's core.autocrlf to TRUE (meaning anytime I checkout code with Git it converts LF to CRLF on my Windows box) Coder would correctly flag an error about invalid end-of-line characters as well as the missing single \n at the end of the file.

I realize that's not the exact repro steps in the original post...

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes
Status: Active » Closed (won't fix)

Coder 7.x is frozen now and will not receive updates. Coder 8.x-2.x can be used to check code for any Drupal version, Coder 8.x-2.x also supports the phpcbf command to automatically fix conding standard errors. Please check if this issue is still relevant and reopen against that version if necessary.