active-trail missing from trail path

Hey Bob,

Thanks for your remarks.

I think I already explained this in some other posts; the menu items (<LI> elements) in the active route get the "active-trail" class, and hyperlinks (<A> elements) pointing out to the current page get an "active" class, they've nothing to do with each other and shouldn't be replaced, changed, etc.

Also, if you need to style the active trail:

.sf-menu li.active-trail a.menuparent {
  color: #ffffff;
}

Hope it helps.

This issue doesn't seem to be fixed, right?
Even in 1.9beta2 I don't get any active-trail classes anywhere in my superfish menu...

This is actually a core issue in Drupal 7, because there are no active-trail classes showing up anywhere in Nice Menus either.

The patch from http://drupal.org/node/942782#comment-4417194 works for me.

So the patch works for your nice menus?
For (my) Superfish module it doesn't solve the issue...

It worked for Superfish too (set the .active-trail class on the parent <li>). I'm running Drupal 7.2, and tested with Superfish 1.8 and 1.9beta2. However there was mention in the issue comments that the patch may not fix all cases. Cleared your cache?

Damn. I'm spending days to tell people to clean the cache at first, but when it comes to me...
Thanks! ;)

Mehrpadin, in reaction to #1:

I understand but in (my) case using multiple images it is very unlogical to theme the a of the first level when active and theme the li when in active trail..

My case: a navbar with level 1 +2 and a conditional menu (level 3 + 4 + 5), menu block module, which shows the deeper children in the left sidebar when you arrive at a level 2 link.


Actually when going to level >3 css becomes very unlogical (which is a bug):

level 1:
- nothing has an active trail anymore. li only has some obscure classes I need to theme: "sfHover" and "sf-breadcrumb". a doesn't have any good classes.

level 2: li has an active-trail class (yay!) and a doesn't have anything.

level 3 + 4 + 5 (menu block module): these links are themed quite nice: all li + a have an active-trail class.



In my opinion it is of great importance that both the li and the a receive an active trail property. I worked with images and multi-level menus a lot and sometimes both the li and a receive different images. I think one of the main advantages of using superfish (instead of coding yourself a menu) should be that it is easy to theme!

Greetings Wappie

posted by Mehrpadin :

.sf-menu li.active-trail a.menuparent {
  color: #ffffff;
}

Hi

i am new at drupal and don't know much about js, and i have searched for this info for hours !
This above worked perfect for me.
Now my superfish menu looks great with its coloured active menu
Thanks a lot !

Looks like the issue is fixed in the core.

To Wappie: That's not needed, you can use .sf-menu li.active-trail > a for the first level, .sf-menu li li.active-trail > a for the second level, and so on and so forth.

When using navbar setting, active second level trail is not remaining displayed (open/expanded) in Drupal 7.12.
This does work in D6 version (on same server: Nginx, PHP5.3).

This seems to be a theme related issue. Works with Bartik, but not with AdaptiveTheme 7.x-2.2

Hey Stewart,

Are you using v1.9-beta4 ?

Hey mehrpadin,
The latest dev version didn't fix the problem.
Jeff made some comments comments: http://drupal.org/node/1460976

Regards,
S.

Try this one: http://drupal.org/node/1351768 the dev is actually outdated, and email me the URL if it's online.

Hi merphadin,
Thanks for the dev link. This version work well for me but it did not resolve the nav bar submenu defect

I removed this CSS from AT Subtheme navigation.css: ul.sf-menu li ul { display: none; Prevent momentary display of sub menus /* } .

I think Jeff expects the superfish JS to over-ride the CSS declaration.

I'll leave this open so that you may determine whether this is a valid expectation for the JS to override the CSS.
IMHO, Jeff reasoning and intent is correct.

Regards,
Stewart.

The active trail class is only applied to the current page link. None of the parents are marked as "active-trail". This is kinda a big deal. Anyone know of a fix?

Currently I am hacking it out this way:
body.section-online-courses #block-superfish-1 ul li#menu-577-1 a.menuparent ,
body.section-current-students #block-superfish-1 ul li#menu-578-1 a.menuparent ,

IE: The page class corresponds to the menu ID.

I'm using a Superfish menu as the main menu for my site and I really need the active-trail applied properly. For example, I have a section of my site for Live video and I've got a series of URLs..

live/foo/hd
live/foo/low
live/bar/hd
live/bar/low
etc.

When I'm anywhere in the live/* branch of the site, I'd like the Live menu item on my main menu to have the active-trail class so that I can keep it highlighted.

This issue has been open for more than a year, I would be willing to pay money to get this fixed for real.

Same here. Superfish + Context isn't working too.

I use adaptivetheme_subtheme

so I had to go to admin/build/themes/settings/adaptivetheme_subtheme and

Advanced theme settings -> Theme development settings -> Menu Classes
Print the .active classes on menu list items (active classes always print on the anchor).

Advanced theme settings -> Theme development settings -> Primary and Secondary Links Classes
Print the active classes on Primary and Secondary links.

I have active-trail class appearing when the language is set to the 2nd language (Greek), but for the primary language it isn't...

Also note a difference in classes added to the li that contains a 2nd level ul:

Greek:

middle odd sf-item-3 sf-depth-1 sf-total-children-6 sf-parent-children-0 sf-single-children-6 menuparent sfHover sf-breadcrumb

English:

middle odd sf-item-3 sf-depth-1 sf-total-children-6 sf-parent-children-0 sf-single-children-6 menuparent

Also can augment CSS markup with some jQuery to add classes to parent items...

jQuery(document).ready(function($) {	
$(".current-page-link-item").parent(".parent-page-link-item").addClass("has-children");
});	

Just use the CSS selectors you require as these are psuedo-code.

Will reproduce all these asap, before the v1.9 release; thank you all, much appreciated!!

thanks for the comment. I went almost crazy trying to achieve the menu I'm looking for with CSS Rules and a missing active-trail class on the first menu item.

I modified your coding for my need and it looks like this to add the class active-trail to each li when the link within has the class active:

jQuery(document).ready(function() {
$(".active").parent().addClass("active-trail");
});

this solved my issue
cheers

Any update on this issue?

i solved this by updating menu_block module.

I had this issue, but had a number of sites with very similar setup, and only had issue on SOME of the sites.
I'm using D7.18 core, superfish 7.x-1.8 and a custom subtheme of Omega 7.x-3.1
So through trial and error, I have found that the superfish menu settings, on the block config dialogue, make a difference to whether the active-trail class appears or not.
i.e.: If I go Configure Block > Advanced CSS Settings > Helper classes
And I remove the check from "Add item count" and "Add children counter", that causes the active-trail class to dissappear from the li element. However if I put those classes back in, by checking those boxes, the active-trial class returns, and can be styled effectively.
I'm sorry I have no idea *why* - only that this seems to work consistantly for me. Others may be clever enough to work out why :)

more info: I'm also using the "horiztonal" "Default" style in Superfish. In case that makes a difference to people experience.

latest dev still does not give active-trail
like #23 it gives me active-trail on non default language menu
but not on default language

using omega subtheme and core all other module are latest dev/stable releases

I don't see a patch in this issue so active is more appropriate
also changing the version since it appears on the latest dev (that is where the fix should be expected)

EDIT: 1.9beta5 has exact same problems

EDIT2: temporary fix based on #25 (commented out line I don't think its needed)

jQuery(document).ready(function() {
	var al = $(".menu a.active");
	//al.parent().addClass("active-trail");
	al.closest("li.menuparent").addClass("active-trail");
});

Peculiar how this is language specific...

FYI I used this JQuery 'ready' to make mine work (with JQ 1.4.4)

<?php
(function ($) {
	// Superfish Active Trail fix
    var al = $(".menu a.active");
    //al.parent().addClass("active-trail");
    al.closest("li.menuparent").addClass("active-trail");
	
})(jQuery);
?>

(my first post - YAY)

So... those comments starts to be a little old.

Is there a known fix that allows Superfish to get an active trail ?

All I really need is the Active Link to be Highlighted on a Superfish menu.

The above proposed fix...

.sf-menu li.active-trail a.menuparent {
  color: #ffffff;
}

... added in superfish different css and styles did nothing for me (yep, I cleared the cache)

Anything I missed ?

#32. My problem was Active trail not working on the Navbar (works with other styles fine). I used the ".sfHover" attribute in my CSS to change the styling of parent menu links given the absence of active-trail.

I try all updates that I find and never work as spected. I have a nine menú elements, no one have second level, and only works 1,2,8 and 9 elements.

Never asign active-trail class to those menú options.

I think the javascript solutions is the fast one, and it works, but not those above for me.

My propouse is edit page.tpl.php and add this

<script>
(function ($) {
    // Superfish Active Trail fix, fallan todos los elementos del menú escepto 2 primeros y 2 últimos
    var al = $(".menu a.active");
    al.parent().addClass("active-trail");
})(jQuery);
</script>

just on the last of the template.

It works only with node links, but if the submenu is a view menu then doesnt.