Right now we're storing settings in $instance['settings']['filefield_sources']. This is the *wrong* location. It should be $instance['widget']['settings']['filefield_sources']. The location of $instance['settings'] is for widget-independent settings. Because FileField Sources only works on certain widgets and not others, we should be saving the settings in $instance['widget']. Furthermore, Field module provides the capability to set defaults for all these values, which we're already doing. So by saving our values in the correct places, we can get rid of several isset($setting) statements.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | filefield_sources_settings_location-d7.patch | 8.01 KB | quicksketch |
Comments
Comment #1
quicksketchI've committed this patch to correct this issue.
This patch will require all users to re-save their settings. All settings are reverted back to their defaults, since we're now saving/retrieving into the correct location. Considering the number of users is probably still <30 installations (the 1.2beta1 release has only been out for 2 days), I'm not providing an upgrade path.