But I just fixed it :-)

CommentFileSizeAuthor
fullcalendar_colors_hook_uninstall_fix.patch649 bytesaspilicious

Comments

aspilicious’s picture

aspilicious commented
Status: Active » Needs review
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: [beta blocker] fullcalendar_colors_uninstall is broken. » fullcalendar_colors_uninstall is broken.
Assigned: aspilicious » Unassigned
Status: Needs review » Fixed

http://drupalcode.org/project/fullcalendar.git/commit/ffe6839

geerlingguy’s picture

geerlingguy commented

Isn't there a more Drupal-y way of doing variable deletions?

[Edit: Just realized... no way of knowing how many variables there might be, so this is probably the best solution, unless we have a db table to hold all the color values instead of putting them in the variables table :-)]

aspilicious’s picture

aspilicious commented

I looked at a database table and that's kind of a mess. When saving the admin form we would have to run again through all the colors and db_merge them.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

I borrowed this method from Pathauto, since it also has to delete variables that it dynamically created.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.