Howdy,

very usefull module!

Only a thing that could help saving some time would be to let some roles (ex: admin) have their revision approved and published directly without going through moderation.

Every time i need to edit posts enabled for revision_moderation on my site, i have to:
1. edit the node
2. publish it
3. go to pending revisions page
4. make last revision current
5. delete old revision

Letting admins skip steps 3,4,5 would make editing nodes 60% faster ;)

CommentFileSizeAuthor
#6 non-admin.patch971 byteswebchick

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

You could probably do this in the workflow/actions system. Let admins move things from pre-published to published in one step, and setup actions so when something gets moved to published, publish it.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Actually, this request has come up again, and in testing the 5.x port I agree this is a huge pain in the butt. ;)

So let's talk about this. We have a couple options:
a) Exempt people with 'node administrator' privileges from the revision moderation system.
b) Have revision_moderation define a 'bypass revision moderation' permission or something.

The advantage of b) is that this functionality could be switch off-able if you want *everyone* to have to jump through this hoop, admins included. On the other hand, people with a) can delete or edit any node in the whole system (and even switch off revision control entirely), so it probably makes sense to just trust them with editing revisions directly. :P

Thoughts?

mrtoner’s picture

mrtoner commented

In my applications, option (a) would be preferable. I can't see any reason to force the node into moderation when a user with administrate nodes permission can then simply publish it.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

My preference is a) as well. Unless someone can come up with a good reason for it to be b), that's what I'll implement (unless jimmygoon gets to it first :D)

jimmygoon’s picture

jimmygoon commented

heh. having like 4 different threads in different areas is confusing.

What about this:
two tiers of permissions to assosciate with module:
"content approved without moderation" -- then you the admin would be allowed the permission and then you could have "editors" and check that role for them...

is that coherent? its really late... where is HEAD at anyway?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Fixed
StatusFileSize
new non-admin.patch971 bytes

I committed a fix for this (attached); the revision moderation logic now only executes for users who don't have administer nodes privileges.

Please test.

luti’s picture

luti commented
Version: master » 5.x-1.x-dev

Yes, making a module useless... ;-)

I am the site administrator and am also creating almost all of the content. When working on some existing content changes for a few days, I'd find useful to have a possibility to keep the old content for visitors, until the new one is 100% ready. That module would be just fine for that, but with that patch, a new partially adapted (and, untested...) content is published immediately...

Is it really such a problem just to press "Publish" after you make all of the changes of a content (this probably takes much more time)?!

Or, implement this patch at least as an option, easy to switch off. I really hate to take care to revert this patch every time after an update to this module would be installed...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Hm. Ok, that's a use case for making it a setting. I'll make a separate issue for that.

marcoBauli’s picture

marcoBauli commented

tryed today on 4.7 as soon as i got back to office and the fix works great! Thank you :)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
marcoBauli’s picture

marcoBauli commented
Status: Closed (fixed) » Active

reopening as does not seem to work anymore with the latest version (v 1.20.2.14 2007/02/20)

The working patch above was:

if ($node->nid && $node->revision_moderation == 1 && !user_access('administer nodes')) {
     switch ($op) {
       case 'view':

and in the latest version the same lines are changed to:

  if ($node->nid && $node->revision_moderation == 1 && (!user_access('administer nodes') || !variable_get('revision_moderation_exempt', 1))) {
    switch ($op) {
      case 'prepare':

..might that be a clue? thx

marcoBauli’s picture

marcoBauli commented

ps: Drupal 4.7.2 here

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Postponed (maintainer needs more info)

Hm. Could you maybe clarify what you mean by 'does not work anymore' ? I just tried on a 4.7.6 install, and my admin user is exempt, and my 'peon' user gets revisions in moderation. Could you give me steps to reproduce your behaviour?

The addition of the variable check was in case people don't want _anyone_ to be exempt from posting. But the exemption is enabled by default.

marcoBauli’s picture

marcoBauli commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

i got fooled by the fact that a new revision was created even if i was submitting content as 'admin'. But this is the normal behaviour if 'create new revision' workflow is checked!

sorry about that, works sweet :)

mrf’s picture

mrf commented
Status: Closed (fixed) » Active

I know this is late in the game, but I have a use case for option b (Have revision_moderation define a 'bypass revision moderation' permission).

I have two roles with access to the same content type (a custom user profile). Faculty need to have their profile changes published immediately, Student's profiles should go into moderation. Faculty can't have administer nodes permission if I want to sleep at night.

I will be attempting to create a patch to add this option.

My question is, should this be enabled by default, or should there be another checkbox under 'Exempt administrators from revision moderation' for 'enable role based moderation bypass'

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Closed (fixed)

@mrf: That sounds reasonable. Could you create a separate issue for "Allow moderation exemption by permission" and post a patch there? This issue is many months old.