Is alphabetical browsing like what in artist module a usable/helpful feature? If it is, attached is what I have done to accomplished it. Somehow there is a problem in creating a patch on my machine(windows) so Im just uploading the entire filestore2.module.

Thanks

CommentFileSizeAuthor
#5 filestore2.patch3.47 KBJhef.Vicedo
#3 drupal_736.3 KBerikhopp
filestore2.module20.38 KBJhef.Vicedo

Comments

gordon’s picture

gordon commented

Please create a patch. This make it alot easier to see exactly what you have done, and determine if I will accept this patch. See http://drupal.org/node/324 on how to create a patch under windows.

Jhef.Vicedo’s picture

Jhef.Vicedo commented

I have followed the instructions there. Sometimes I can get this to work. Like what I did in the event module of killes. But later on, I have this unrecognizable patches. Like also what I have to killes for his event module. So I stopped patching coz I can't it to work.

I hope you understand. Thanks

erikhopp’s picture

erikhopp commented
StatusFileSize
new drupal_736.3 KB

ok - i made a patch for you using your edited module.

i am using windows too - try tortoise cvs - http://www.tortoisecvs.org/ - it works great.

erik.

gordon’s picture

gordon commented

I don't want to be dificult, but can you please recreate this patch against the latest version of filestore2, otherwise I am going to be removing functionality.

Jhef.Vicedo’s picture

Jhef.Vicedo commented
StatusFileSize
new filestore2.patch3.47 KB

Hope this patch works..

gordon’s picture

gordon commented

I have taken a look at it, and it looks fine, I would however like to know the opinions of other people.

Could this be done another way, by an external module?
Would this be of use to other node types?
What about hooking it into taxonomy?

Don't get me wrong, At this stage I have no opinion on this patch. Code wise it is perfectly fine, and I will include it. My question is should it be included?

Like m taxonomy_fm module that I distribute from my site, I didn't include it in filestore2, but made it a stand alone, and I user it for all node types.

+1 coding/implementation
-0 design

gordon’s picture

gordon commented

Now in cvs.

Anonymous’s picture

(not verified) commented