Posted by socketwench on April 26, 2011 at 7:25pm
3 followers
| Project: | Organic groups |
| Version: | 7.x-1.x-dev |
| Component: | og-ui |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
When the "Group manager full permissions" setting is disabled, group managers can no longer edit their own groups, even if they are in a drupal user role granting "edit own content", and the group grants group admins group editing rights.
Comments
#1
You need to grant the manager the right *group* role, not the Drupal user role.
#2
The Group Manager is not available for selection under Group > People, so no group roles can be applied to them. See attached. Re-adding the group manager using "Add People" results in an error.
#3
You marked the version as -dev, but I think you are not using latest -dev.
#4
I downloaded the Apr 26th tarball and installed it, but the problem persists, even for new groups. Is there a newer version?
#5
Did you enable and ran og migrate?
#6
No, I didn't think this was necessary as this is a completely new drupal 7 site and not an upgrade from 6. Enabling and running the migration operation results in zero posts migrated -- which sounds right to me given the site is new.
Managers still cannot edit their groups. Am I still missing something?
#7
> Re-adding the group manager using "Add People" results in an error.
What error do you see?
#8
Is it on a single group or all groups?
#9
Exception: Group membership for entity user with ID 15 for group ID 3 (StarReader) already exists. in og_membership_create() (line 951 of /home/deninet/public_html/sites/all/modules/og/og.module).
Picture attached.
#10
It happens on all groups. Once "group manager full permissions" is deselected, all group managers affected on all groups to which they own.
#11
I have overhauled the query on og-ui.admin .
Can you please grab latest -dev (from git, or wait a few hours) and try again.
#12
There we go! Now I can assign the group manager a role -- and thus admin privileges. This works on existing groups.
When a user creates a *new* group, however, they are locked out of their new group. My first thought is that the group manager should be assigned a role at the time of group creation. And that there should be a setting under Global Roles that determines which role this is.
#13
> My first thought is that the group manager should be assigned a role at the time of group creation. And that there should be a setting under Global Roles that determines which role this is.
Nice idea. Patches are welcome ;)
#14
I've barely made any patches before, but I can certainly give it a shot. I'm on a business trip this week, but I'll have plenty of time for the next week after Friday.
#15
Thinking of it, it's better to manage this scenario via Rules integration.
#16
The thought occurred to me to, but it seems like a heavy way to solve the issue. A site admin would have to bring in an entire module just to solve this one issue, an issue that could catch them off guard just like it did to me. Personally, I'd rather have it built in to OG to keep down the number of contrib modules I'd need to include on the site.#17
Here's an idea: Instead of using Rules or modifying the existing modules, why not create a submodule that relies on core Triggers/Actions? This would serve as base for other triggers and actions to include in OG in the future.And then I notice the Rules code you've already written. How embarrassing...
#18
Automatically closed -- issue fixed for 2 weeks with no activity.