At the last step of module updates, the submit button action is incorrectly set by domain_form_alter. $domain = domain_initial_domain(); returns null. Since this is an early stage of bootstrap, perhaps we may need to domain_init() in domain_initial_domain(), per se:

function domain_initial_domain($domain = array()) {
  static $initial;
  if (!isset($initial) && !empty($domain)) {
    $initial = $domain;
  }
  if (!isset($initial)) domain_init();
  return $initial;
}

Comments

agentrickard’s picture

Status: Active » Postponed (maintainer needs more info)

Lovely.

How do I actually replicate the error?

omercioglu’s picture

*Goto "Available Updates".
*Check for updates
*Goto "Update" tab
*Select one of the modules to be updated.
*Click "continue" on each screen until you end up at "Clipboard4.jpg"
Now, you will see that the submit action is garbled, because $domain variable in "domain_form_alter" is null.

agentrickard’s picture

I never get to that screen. It just downloads using BatchAPI.

agentrickard’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new534 bytes

Here's a patch that should work, though.

omercioglu’s picture

Status: Needs review » Reviewed & tested by the community

Works as expected now, thank you.

agentrickard’s picture

Status: Reviewed & tested by the community » Fixed
StatusFileSize
new532 bytes

Committed. Patch for 7.x.2 attached.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.