Dealing with existing nodes

When Private is enabled there is no way to populate the private table. As a result, existing nodes remain absent from the table. This is a problem as other modules begin to use this access information (see http://drupal.org/node/113674).

The following update solves the problem for MySQL (I'd rather have someone else write the Postgres version).

In private.module

/**
 * Implementation of hook_nodeapi().
 *
 * - "delete", "insert", and "update":
 * The module must track the access status of the node.
 */
function private_nodeapi(&$node, $op, $arg = 0) {
  switch ($op) {
    case 'load':
      $result = db_fetch_object(db_query('SELECT * FROM {private} WHERE nid = %d', $node->nid));
      if (!isset($result->private)) {
	    $node->private = false;
	    $node->private_missing = true;
	  } else {
	    $node->private = $result->private;
	  }
      break;
    case 'delete':
      db_query('DELETE FROM {private} WHERE nid = %d', $node->nid);
      break;
    case 'insert':
      db_query('INSERT INTO {private} (nid, private) VALUES (%d, %d)', $node->nid, $node->private);
      break;
    case 'update':
	  if ($node->private_missing) {
	    db_query('INSERT INTO {private} (nid, private) VALUES (%d, %d)', $node->nid, $node->private); }
	  else {
        db_query('UPDATE {private} SET private = %d WHERE nid = %d', $node->private, $node->nid); }
      break;
  }
}

in private.install

function private_install() {
  switch ($GLOBALS['db_type']) {
    case 'mysql':
    case 'mysqli':
      db_query("
          CREATE TABLE {private} (
            nid int(10) unsigned NOT NULL default '0' PRIMARY KEY,
            private int,
            KEY private_nid (nid)
          ) /*!40100 DEFAULT CHARACTER SET utf8 */;
      ");
      db_query("
          INSERT INTO {private}
            SELECT
              n.nid, 
              0 
            FROM
              {node} n
              LEFT JOIN {private} p ON
                p.nid=n.nid 
            WHERE
              p.private is null	
            ORDER BY n.nid
      ");	  
      break;
    case 'pgsql':
      db_query("
          CREATE TABLE {private} (
            nid int NOT NULL default '0',
            private int,
            PRIMARY KEY (nid));
      ");
      break;
  }
}

It should not alter in any way standard private module behavior, so I'd really ask you to adopt it as a standad.