When users see this error, the obvious question is what times can I make a reservation when I can get 2 items of type X.

CommentFileSizeAuthor
#6 Create Reservation | internal.ctn5_.org_.jpg123.11 KBraytiley

Comments

darrick’s picture

darrick commented

The way I coded this is ...

- Check for conflict due to conflicting times. If so show conflict grid.
- Check if the user selected too many of the same item. If so show the "You've selected too many" error.

I.e. If you have two dv cameras. One is reserved. Another user tries to create a reservation during the same time frame for three dv cameras. Validation would be: conflict grid for choice 1, pass for choice 2, "You've selected too many" for choice 3.

Probably a good idea to change this error to: "You've selected too many . We only have 1 in the current inventory"

I'll also check to make sure this error isn't over riding the conflict grid error.

darrick’s picture

darrick commented
Status: Active » Closed (works as designed)

I changed the wording to make this error less confusing.

kreynen’s picture

kreynen commented
Status: Closed (works as designed) » Needs work

This does not solve the issue. When reserving dozens of items, I being told I can't reserve them at this time doesn't tell me when I can reserve them.

The conflict grid used to be displayed when this happened. Without it users have can only use trial and error to find an opening.

darrick’s picture

darrick commented

I've tested this and it works. If you have x total bucket items in inventory. And y are currently reserved at the same time you are trying to make a reservation for z items. Then the conflict grid will show for y items which have a time conflict. The "You've selected too many" error shows for z-x-y items.

I.e. You have 12 cameras. 4 are reserved at the same time. You are trying to reserve 14 cameras.

You would get no errors for the first 8 cameras.
You would get the conflict grid for the next 4.
You would get "You've selected too many" for the remaining two.

darrick’s picture

darrick commented
Component: User interface » Code
Status: Needs work » Fixed

6.x http://drupalcode.org/project/merci.git/commit/6e9cd31

7.x http://drupalcode.org/project/merci.git/commit/22360a3

raytiley’s picture

raytiley commented
Status: Fixed » Active
StatusFileSize
new Create Reservation | internal.ctn5_.org_.jpg123.11 KB

I've recreated this on my site.

It happens when a you try to reserve a resource that is unavailable. When trying to reserve that same resource during a conflicting time period there is no conflict grid shown.

-ray

darrick’s picture

darrick commented

I'm guessing I only fixed this for buckets. Can you confirm this issue is only for resources?

darrick’s picture

darrick commented
Status: Active » Fixed

6.x http://drupalcode.org/project/merci.git/commit/75cb71f

7.x http://drupalcode.org/project/merci.git/commit/b982bfe

kreynen’s picture

kreynen commented
Status: Fixed » Needs review

We have enough people involved in MERCI now to actually QA updates, so please leave the issues as need review until someone else confirms the update solves the problem in another environment/workflow.

Telling people issues are fixed that aren't isn't helping anyone.

raytiley’s picture

raytiley commented

I pulled and tested the latest code and darrick's change in #8 works in D7. The conflict grid is now displayed when trying to reserve the same resource for conflicting times.

-ray

kreynen’s picture

kreynen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.