Sure you could go into the admin and add a ?buster there but it's a bit difficult to remember for this particular file. Adding the default query string in the script tag should do the trick.

CommentFileSizeAuthor
#7 1142732.patch1.16 KBbleen
#4 omniture-comment-cleanup-1142732-4.patch1.04 KBsperks
#1 omniture-add_cache_buster-1142732-1.patch1.04 KBaaronott

Comments

aaronott’s picture

aaronott commented
Status: Active » Needs review
StatusFileSize
new omniture-add_cache_buster-1142732-1.patch1.04 KB
sperks’s picture

sperks commented

I tested this patch and it works fine. We have around 30 sites (which could be increasing to ~70/80 before the end of the year) using one s_code.js file, and busting the cache manually every time is becoming increasingly time consuming.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Great idea. If I'm a little nitpicky then the comment should be a sentence (capital, ends in a period). And "ripped" feels like slang - maybe "Copied" would be more easily understood by folks in the future.

Thanks for providing this!

sperks’s picture

sperks commented
StatusFileSize
new omniture-comment-cleanup-1142732-4.patch1.04 KB

This would be my first patch, so just to make sure I've got the local process down, I'm committing the nitpicky changes.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: There is no way bust the cache if there is a change to the s_code.js file » Bust the cache using core's variable for query string in case there is a change to the s_code.js file
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Hi Sperks - looks perfect to me.

Thanks to both of you for your help - now committed http://drupalcode.org/project/omniture.git/commit/7a18222

This now needs to be ported to 7.x. Are either of you able to do that?

sperks’s picture

sperks commented

I'm still primarily on D6 but will take a look later to see where things differ.

bleen’s picture

bleen commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1142732.patch1.16 KB

This should definitely be added the D7 version...

bleen’s picture

bleen commented
Status: Needs review » Fixed

Since this was a super basic port and no one had any thoughts on it for over a week, I went ahead and committed it.

http://drupalcode.org/project/omniture.git/commit/26a4cc2

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.