Hi,

immediately after installing the 6.x-1.10 update, one "Create node reference" link disappeared from the $links section of one content type. This link referenced a content type under access control. Another Nodereference from URL link (on the same content type) did not disappear; this link referenced a content type without access control.

This occurs for user #1 which definitely can access the restricted content type, so this should not be a permission issue.

CommentFileSizeAuthor
#11 nodereference_url_links-d6.patch1.53 KBquicksketch
#11 nodereference_url_links-d7.patch1.35 KBquicksketch
#4 nodereference_url__nodelinks_fix.patch1.46 KBzsim

Comments

quicksketch’s picture

quicksketch
he/him
commented

Probably the same as #1142440: Wrongfully named links generated when having multiple content types refering to same node type (wrong scoped variable)

asb’s picture

asb commented

Thanks; the patch from #1142440 applies cleanly, but the lost link does not reappear; either it's a different issue, or the patch might not be perfect.

steeph’s picture

steeph commented

I have the same problem. All but one link are not there anymore.

Edit: Sorry, downgrading to 6.x-1.8 brought the links back. So it might rather be a problem in 6.x-1.9 and not 6.x-1.10.

zsim’s picture

zsim commented
StatusFileSize
new nodereference_url__nodelinks_fix.patch1.46 KB

Hi, everyone!

Please, try out my patch.

asb’s picture

asb commented

Hi,

the patch from #4 collides with the patch from #1142440. However, it applies cleanly against 6.x-1.10 and fixes the issue for me. I dont know yet if there are any negative side effects.

Thanks!

zsim’s picture

zsim commented

I`ve just looked at #1142440. You can apply my patch and do not use the #1142440, it solves both of the problems.

asb’s picture

asb commented
Status: Active » Reviewed & tested by the community

Great!

it-cru’s picture

it-cru
Primary language English
Location Munich
commented

only using patch from #4 works for me too

goldlilys’s picture

goldlilys commented

Is it just me but even after applying the patch on #4, though I do get the "add new content" text back, the links point to an Array and not the node id so the url doesn't get populated correctly.

Downgrading to 6.x-1.8

asb’s picture

asb commented

@goldlilys: What's in the array?

PS: I believe downgrading is not a good idea:

The 1.10 release of Node Reference URL Widget corrects an XSS security hole. All previous versions of Node Reference URL Widget would not sanitize the node title when displaying the referenced node. Upgrading is recommended for all users.

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new nodereference_url_links-d7.patch1.35 KB
new nodereference_url_links-d6.patch1.53 KB

@goldlilys: Make sure you're running the latest version of Drupal 6. I don't think all versions of Drupal 6 supported arrays for the query string.

I've committed this version of the patch with a port for Drupal 7. It's identical to #4 except I flipped around the order of the array so that it's $instances[$target_type][$field_name] instead of $instances[$field_name][$target_type]. This makes it so that the "alternative format" is only used when there are two Node Reference URL Widget on the same content type instead of doing it when there are two Node Reference URL Widgets on the entire site.

goldlilys’s picture

goldlilys commented
Version: 6.x-1.10 » 6.x-1.11

Alright i upgraded to 6.x-1.11 . It works now, but the link still looks like this /node/add/[content-type]/nid?Array .

The Array word is literally "Array" string . Not sure where that's coming from. And yes, my drupal is the newest 6.20 version. Besides the Array string being added, everything else works fine. It populates the node reference and gets saved.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

steeph’s picture

steeph commented

Oh, I forgot to report. It's working fine now after I updated to 6.x1.11. Thx!

ophelia’s picture

ophelia commented

Thank you, zsim! Your patch worked great for me.

Here was my issue after updating this module, in case other people run into a similar problem:

I am using a complicated views photo gallery involving about 6 modules in which the gallery images are saved to a directory created based on the gallery date, which gets passed through the URL and automatically filled in a hidden date field in the image form. After I updated to the latest Node Reference URL version 6.x-1.11, suddenly when I clicked "Add photo" from my gallery, the URL read ".../node/add/gallery-image/4454?Array&gids[]=" instead of "../node/add/gallery-image/4540?destination=photos%2F2011-08-31". (or whatever the gallery date is) This was working beautifully for months until the update and it took me almost an entire day to figure out that it was THIS particular module update that was changing where my photos were getting stored. Thanks to zsim for this miracle patch and hopefully if someone else is using this module similarly, maybe this will save you hours of work too. : )