domain_blocks_save fails when unchecking domain assigments for blocks

Hi,

if I uncheck a domain assigment, I get an sql error (at least when using MySQL), because The IN() condition comes out empty. Instead of imploding the arguments and setting the operator to 'IN', you can simply pass an array. It works then. Following a patch to fix it (tested using current release of D7 and MySQL as DB adapter). Attached you find the modified file.

Cheers,

Martin

// $Id: domain_blocks.module,v 1.6 2011/02/11 20:38:19 nonsie Exp $

Index: sites/all/modules/domain_blocks/domain_blocks.module
===================================================================

@@ -98,14 +98,15 @@
// Unset previously checked values that are now unchecked
$domains_to_be_removed = array_diff($previous_domains, $current_domains);
if (!empty($domains_to_be_removed)) {
- $domains_to_be_removed = implode(',', $domains_to_be_removed);
$realm = 'domain_id';
if (isset($domains_to_be_removed)) {
db_delete('domain_blocks')
->condition('module', $module)
->condition('delta', $delta)
->condition('realm', $realm)
- ->condition('domain_id', $domains_to_be_removed, 'IN')
+ ->condition('domain_id', $domains_to_be_removed)
->execute();
}
}