Invalid argument supplied for foreach() in trigger.module. Message in all pages.

The patch is against Drupal 6.20.

#2 seems to be working fine for us ... RTBC

NOT RTBC. The patch in #2 is a work-around, not a fix.

Unless someone else can reproduce the error, this issue should be closed.

patch in #2 fixed the problem, thank you!

According to the hook_hook_info() documentation, this error should not happen.

Would anyone who is still experiencing this problem or who has used the patch from #2 to solve it please apply this patch instead?

Then cut-and-paste any generated warning into this issue so we can find the real source of this bug.

Im getting this now with my upgrade to 6.22 from 6.20.. tried the patch but seemed to fail, going to manually adjust the code

patch -p0 < troubleshooting_trigger_hooks-1143174-10.patch
patching file b/modules/trigger/trigger.module
Hunk #1 FAILED at 169.
1 out of 1 hunk FAILED -- saving rejects to file b/modules/trigger/trigger.module.rej

Ok manually changed the page.. here is the full function that removed the warnings, but gave me another issue with another module, not sure if its related, going to look at that next..

drupal 6.22

/**
 * Implementation of hook_forms(). We reuse code by using the
 * same assignment form definition for each node-op combination.
 */
function trigger_forms() {
  $hooks = module_invoke_all('hook_info');
  foreach ($hooks as $module => $info) {
    //foreach ($hooks[$module] as $hook => $ops) {
    foreach ($info as $hook => $ops) {
      if (!is_array($ops)) {
        $message = 'Module "%module" has defined a hook "%hook" whose value @value is not an array.';
        $value = str_replace(
          array("'", "\n"),
          array('"', '\n'),
          $ops
        );
        $args = array(
          '%module' => $module,
          '%hook' => $hook,
          '@value' => $value,
        );
        drupal_set_message(t($message, $args), 'error');
        watchdog('trigger', $message, $args, WATCHDOG_ERROR, 'http://drupal.org/node/1143174');
        continue;
      }		
		  foreach ($ops as $op => $description) {
        $forms['trigger_'. $hook .'_'. $op .'_assign_form'] = array('callback' => 'trigger_assign_form');
      }
    }
  }

  return $forms;
}

the new error im getting and not sure if its related to the change in trigger form..

Module "service_links" has defined a hook "group" whose value service_links is not an array.
Module "service_links_alter" has defined a hook "group" whose value service_links is not an array.

which is not an array sorta kinda makes me think it might be related..

yea in triggers admin menu, the service links tab is empty..

ST

Redirecting...

#1199322: warning: Invalid argument supplied for foreach()