'Anonymous' string assigned to comment author's name [#1143888]

In the antispam.module there is an assignation of the comment author's name with the string 'Anonymous'. I dont know if this is voluntary but this override any submitted name.

See 7-x-1.1 code of antispam.module at line 971:

/**
* Implements hook_comment_load().
*/
function antispam_comment_load($comments) {
  // add signature and spaminess to the $comments object

  foreach ($comments as $comment) {
    $rec = db_query("SELECT signature, spaminess FROM {antispam_spam_marks} WHERE content_type='comment' AND content_id=:content_id", array(':content_id' => $comment->cid))->fetchObject();
    if ($rec) {
      $comment->signature = $rec->signature;
      $comment->spaminess = $rec->spaminess;
    }
    else {
      $comment->signature = '';
      $comment->spaminess = 0.0;
    }
    if ($comment->uid == 0) {
      $comment->name = variable_get('anonymous', t('Anonymous'));
    }
  }
}

Comment	File	Size	Author
#11	antispam-1143888-11-test-only.patch	3.18 KB	tim.plunkett
#11	antispam-1143888-11-fix.patch	3.54 KB	tim.plunkett
#4	antispam-remove-comment-annonymous-1143888-4.patch	374 bytes	alphageekboy

Comments

Comment #1

versvs commented 4 June 2011 at 08:32

This really made my day!! I've been crawling through this error for a time and commenting these lines really made it disappear.

I'd recommend submitting it to master so that this error doesn't get back like a hunting ghost when a new version is released :)

Thank you!

Comment #2

markpeak commented 16 November 2011 at 11:44

Confirm this problem. It should display username field with 'non-verified' instead.

Comment #3

emilymoi commented 28 December 2011 at 16:09

I don't see why antispam needs to blow away the name property at all. Can't we just remove this completely:

if ($comment->uid == 0) {
      $comment->name = variable_get('anonymous', t('Anonymous'));
}

Comment #4

alphageekboy commented 19 March 2012 at 15:13

Version:	7.x-1.1	» 7.x-1.x-dev
Status:	Active	» Needs review

Status	File	Size
new	antispam-remove-comment-annonymous-1143888-4.patch	374 bytes

Here is a simple patch that removes the override of anonymous for comments. We have a site that uses the name field where visitors do not need to be authenticated to make comments and we need to retain the username.

Comment #5

NitroPye commented 27 April 2012 at 19:43

Having a similar issue not sure if it is the same issue.

In the admin panel for spam no matter what the user "Anonymous (Not verified)" is applied. If I got to the comment it is an actual user. I applied the fix above but that did not work for me.

It would also be nice if the Author column was a link to the author but that is not part of this bug.

Comment #7

Anonymous (not verified) commented 19 May 2012 at 17:54

Also having this problem, guest comments are all displayed as "Anonymous". Have you considered incorporating one of the patches provided above?

Comment #8

stevenx commented 15 June 2012 at 14:25

works.

Comment #9

kmonty

He/Him

Berlin, DE + SF, CA

commented 14 July 2012 at 00:13

Status:

Needs review

» Reviewed & tested by the community

R+T patch in comment #4

As far as I can tell, there is no need for this module to update the commenter name. The antispam_spam_marks table doesn't store any name data, so there is nothing to update in the first place. The comment.module already handles this.