The email about the approval being granted goes to the user doing the approval and the approver/approvee names are reversed. To fix it, change line 1419 of buddylist.module from:
$replacements = buddylist_translation() + (($op == 'approval') ? buddylist_approval_mail_replacements($buddy, $user) : buddylist_mail_replacements($buddy, $user));
to:
$replacements = buddylist_translation() + (($op == 'approval') ? buddylist_approval_mail_replacements($user, $buddy) : buddylist_mail_replacements($buddy, $user));
The if statement on line 1432 was where i orginally thought the problem was, as it also has the same code for both branches, but it turns out that it's supposed to be that way so the if statement is redundant.
Comments
Comment #1
robertdouglass commentedComment #2
robertdouglass commentedCommitted, thanks.
Comment #3
(not verified) commentedComment #4
yched commentedI think this needs to be fixed in 4.7 as well
Comment #5
geodaniel commentedYep, this should be ported back if possible
Comment #6
gnat commentedHere is a patch to the 4.7 dev version:
// $Id: buddylist.module,v 1.48.2.40 2007/01/05 18:49:23 fago Exp $Comment #7
gnat commentedWoops, uploaded an empty file. Use this one instead.
Comment #8
simon georges commentedChanging status, as there is a patch.
Comment #9
simon georges commentedActually, closing, as 4.x is not supported any more.