The email about the approval being granted goes to the user doing the approval and the approver/approvee names are reversed. To fix it, change line 1419 of buddylist.module from:

$replacements = buddylist_translation() + (($op == 'approval') ? buddylist_approval_mail_replacements($buddy, $user) : buddylist_mail_replacements($buddy, $user));

to:

$replacements = buddylist_translation() + (($op == 'approval') ? buddylist_approval_mail_replacements($user, $buddy) : buddylist_mail_replacements($buddy, $user)); 

The if statement on line 1432 was where i orginally thought the problem was, as it also has the same code for both branches, but it turns out that it's supposed to be that way so the if statement is redundant.

Comments

robertdouglass’s picture

Priority: Normal » Critical
robertdouglass’s picture

Status: Active » Fixed

Committed, thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)
yched’s picture

Status: Closed (fixed) » Active

I think this needs to be fixed in 4.7 as well

geodaniel’s picture

Version: 5.x-1.x-dev » 4.7.x-1.x-dev

Yep, this should be ported back if possible

gnat’s picture

StatusFileSize
new0 bytes

Here is a patch to the 4.7 dev version:

// $Id: buddylist.module,v 1.48.2.40 2007/01/05 18:49:23 fago Exp $

gnat’s picture

StatusFileSize
new599 bytes

Woops, uploaded an empty file. Use this one instead.

simon georges’s picture

Status: Active » Needs review

Changing status, as there is a patch.

simon georges’s picture

Status: Needs review » Closed (won't fix)

Actually, closing, as 4.x is not supported any more.