Closed (fixed)
Project:
phpBB2Drupal
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
31 Jan 2007 at 03:12 UTC
Updated:
30 Jun 2009 at 01:24 UTC
If this is only a DragonflyCMS problem, feel free to "won't fix".
We have some banned users on our site, but all users are being imported as active. The code is checking the user_active field, which is always 1 (again, in my database). rather, user_level == 0 means a banned user. user_level looks like it's tied to roles, actually, since it's 1 for most users and 2-3 for users with elevated permissions.
Here's a patch that checks to see if user_level is greater than 0. If so, make the user active; else set them to blocked.
| Comment | File | Size | Author |
|---|---|---|---|
| user-status.patch | 738 bytes | webchick |
Comments
Comment #1
beginner commentedThe problem is that if I commit this patch, it's all those who use vanilla phpbb who will start complaining.
I am perfectly ok with committing some DragonflyCMS-specific patches, but obviously only as long as it does not break things for the majority of users.
One would need to make sure, but I don't think $user->user_level is set on a vanilla phpbb. You could use isset($user->user_level ) and if it is, override the status value.
Comment #2
webchickIt was in the table schema you posted over at the DragonflyCMS issue, but it might mean something totally different in the vanilla version.
I actually don't think DragonflyCMS-specific (or any non-vanilla-PHPBB-specific) patches should get committed to this module; when I'm done, I'll roll all of those specific changes up and post them over @ http://drupal.org/node/78509 as you asked me to back in, oh... August or something. ;) I was just reporting it separately in case it was a bug with vanilla PHPBB as well. If not, feel free to won't fix!
Comment #3
naheemsays commentedclosing old issues that may no longer be relevant.