Some patches has "Failed" status not due to bugs in them, but a bug in the test case, it was an error in selecting role where D7 differ from D6 in creating new users, every new user created in test case must at least have two roles, the one created by drupalCreateUser() and the Authenticated role which is giving to every user in the system.

CommentFileSizeAuthor
#5 fix_roles_selection_in_test_case-1144510-5.patch3.75 KBgood_man
#1 fix_roles_selection_in_test_case-1144510-1.patch3.23 KBgood_man

Comments

good_man’s picture

good_man commented
Assigned: Unassigned » good_man
Status: Active » Needs review
Issue tags: +simpletests
StatusFileSize
new fix_roles_selection_in_test_case-1144510-1.patch3.23 KB
good_man’s picture

good_man commented
Priority: Normal » Critical
Issue tags: -simpletests

Moving to critical, other release-blocker patches need this in order to test them.

good_man’s picture

good_man commented
Issue tags: +simpletests

I HATE TAGS.

Status: Needs review » Needs work

The last submitted patch, fix_roles_selection_in_test_case-1144510-1.patch, failed testing.

good_man’s picture

good_man commented
Status: Needs work » Needs review
StatusFileSize
new fix_roles_selection_in_test_case-1144510-5.patch3.75 KB

Another check for ACL module, seems Drupal Bot can't get it enabled.

good_man’s picture

good_man commented
Status: Needs review » Fixed

Changes committed, waiting for the packaging script.

Automatically closed -- issue fixed for 2 weeks with no activity.