Allow vertical tabs elements to have #title and #description values

+++ b/includes/form.inc
@@ -3526,12 +3526,66 @@ function form_process_vertical_tabs($element, &$form_state) {
-  $element = $variables['element'];
+  $element = &$variables['element'];

This tweak could use a small code comment.

+++ b/includes/form.inc
@@ -3526,12 +3526,66 @@ function form_process_vertical_tabs($element, &$form_state) {
+
+

Duplicate newline.

+++ b/includes/form.inc
@@ -3526,12 +3526,66 @@ function form_process_vertical_tabs($element, &$form_state) {
+  $element += array(
+    '#title_display' => 'before',
+  );
...
+  // If #title is not set, we don't display any label or required marker.
+  if (!isset($element['#title'])) {
+    $element['#title_display'] = 'none';
+  }

Let's move the additional munging of #title_display right below the initial default code.

+++ b/includes/form.inc
@@ -3526,12 +3526,66 @@ function form_process_vertical_tabs($element, &$form_state) {
+  // Add element's #type and #name as class to aid with JS/CSS selectors.
+  $element['#attributes']['class'][] = 'form-item';
+  $element['#attributes']['class'][] = 'form-type-vertical-tabs';
...
+  $output = '<div' . drupal_attributes($element['#attributes']) . '>' . "\n";
...
+  $prefix = '<div class="vertical-tabs-panes">';
+  $suffix = '</div>';
...
+  $output .= "</div>\n";

One wrapper too much. Let's simply add the 'vertical-tabs-panes' class to the outer wrapper. More than one container doesn't make much sense here.

+++ b/includes/form.inc
@@ -3526,12 +3526,66 @@ function form_process_vertical_tabs($element, &$form_state) {
+  // Add a class for disabled elements to facilitate cross-browser styling.
+  if (!empty($element['#attributes']['disabled'])) {
+    $element['#attributes']['class'][] = 'form-disabled';
+  }

Not sure whether this has any [valid] effect here. Can probably be removed.

+++ b/includes/form.inc
@@ -3526,12 +3526,66 @@ function form_process_vertical_tabs($element, &$form_state) {
+  $prefix = '<div class="vertical-tabs-panes">';
+  $suffix = '</div>';
...
+    case 'attribute':

If there's a meaning to 'attribute', then the only possible meaning I could see would be a 'title' attribute on the wrapping DIV.

+++ b/includes/form.inc
@@ -3526,12 +3526,66 @@ function form_process_vertical_tabs($element, &$form_state) {
+    case 'none':
...
+      // Output no label and no required marker, only the children.

Stale reference to "and no required marker".

Powered by Dreditor.

This has the "Needs usability testing" tag - what kind of testing does it need exactly?

I just stumbled over this in a contrib module.

I'd suggest to keep this simple and just get the job done.

Fixed that test failure — of course, the #pre_render needs to check whether any tabs are accessible/visible.

This patch should come back green and could be considered ready.

Feedback, anyone?

#8: drupal8.vertical-tabs-title.8.patch queued for re-testing.

Re-rolled against HEAD.

Feedback, anyone?

Anyone?

#11 applies cleanly to drupal-8.x-dev. I'm not finding any manual errors when viewing forms that contain vertical tabs around the dev site.

If patch is committed it would save ~3 lines for title assertions on vertical tabs.

Was that an RTBC? ;)

#11: drupal8.vertical-tabs-title.11.patch queued for re-testing.

#11: drupal8.vertical-tabs-title.11.patch queued for re-testing.

#11: drupal8.vertical-tabs-title.11.patch queued for re-testing.

Manual testing. Looks find on blocks (admin/structure/block/manage/system/help/configure), account settings (admin/config/people/accounts), filters (admin/config/content/formats/filtered_html)
Content types like articles don't seems to have titles on the vertical tabs to convert. Still rtbc to me.

patch still applies with offsets.

#11: drupal8.vertical-tabs-title.11.patch queued for re-testing.

#11: drupal8.vertical-tabs-title.11.patch queued for re-testing.

Re-rolled against HEAD.

#24: drupal8.vertical-tabs-title.24.patch queued for re-testing.

Hah, playing the re-roll monkey — so lucky to break my own patches :)

This looks like a nice feature/clean-up. We can commit it once we're under thresholds again.

Hm. Actually I guess catch has tried to re-test this several times so guess he's cool to commit this.

Committed and pushed to 8.x.

Der. Needs a change notice.

Change notice: http://drupal.org/node/1886118