The title 'Add a new sIFR rule' appears twice on the 'admin/settings/sifr/addrule' page. The top title should be 'sIFR' as per the rest of the interface.

CommentFileSizeAuthor
#1 sifr.module.page-titles.5.x.patch1.92 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Duplicate title » Display consistent page titles
Category: bug » task
Status: Active » Needs review
StatusFileSize
new sifr.module.page-titles.5.x.patch1.92 KB

That has been a fix for consistency which mistakenly went in with one of the last patches.

Since admin/settings/sifr/edit/# displays only the correct page title 'sIFR rule xyz', admin/settings/sifr/addrule should do that, too.

In general I don't like those duplicate titles. They don't fit into any theme.

Instead, I'd like to propose to rename all titles:

  • sIFR rules
  • Add a new sIFR rule
  • Edit sIFR rule xyz
  • Manage sIFR fonts

This also removes the need for sifr_add_rule().

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: Unassigned » sun
Status: Needs review » Fixed

Committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)