Media: Česká televize (ČT)

Hi,

Have you tried contacting the Emfield maintainer to add this feature, or to become co-maintainer? Adding a module for the sole purpose of adding a provider seems overkill to me.

I did a quick Coder review to check the Coding Standards, see below.

I tried the module with the link at the top, but i got

warning: Parameter 6 to emvideo_ceskatelevize_video() expected to be a reference, value given in /home/quickstart/websites/example6.dev/sites/all/modules/emfield/emfield.module on line 649.

also coder found 4 minor remarks:

sites/all/modules/media____esk___televize____t_/providers/ceskatelevize.inc:
 +214: [minor] Missing period
 +214: [minor] Format should be * Implementation of hook_foo().
 +242: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
 +255: [minor] in most cases, replace the string function with the drupal_ equivalent string functions

Regarding the UTF-8 in domain names, you know they will be appearing shortly: http://www.icann.org/en/topics/idn/ so better be safe than sorry, the speed difference will be neglect-able.

• It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
• lines in README.txt should not exceed 80 characters, see also http://drupal.org/node/447604
• media_ceskatelevize_emfield_providers(): All functions should have doc blocks, especially the hook implementations. See http://drupal.org/node/1354#hookimpl
• ceskatelevize.inc: I think you just copied the documentation from a emfield template. It contains statements that do not apply to your code and it makes it very hard to find actual documentation for the code. Please remove the template-generic messages and convert the rest to fit your provider.
• "$autoplay = $autoplay ? 'true' : 'false';" should be "$autoplay = $autoplay ? 'TRUE' : 'FALSE';"
• @param and @return: the description on the new line should be indented 2 spaces, see here http://drupal.org/node/1354#functions
• I think you should implement hook_theme() to register your theme item, no?
• theme_emvideo_ceskatelevize_flash(): you should sanitize all variables before adding them to $output to avoid possible XSS issues.

@ricoo has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

Closing due to lack of activity. Feel free to reopen if you are still working on this application.