I observed this with Bartik, but I suspect this affects more than just Bartik.

If a color-module-supporting system theme is sub-themed (as per the instructions in http://drupal.org/node/1114190 for Bartik), the subtheme will still ignore any color settings made for the module.

The following patch resolves the issue. Problem is that due to the use of '==' when '!=' should be used, the requested color setting is never applied.

CommentFileSizeAuthor
#1 issue-1145374.patch696 bytesTorenware

Comments

Torenware’s picture

Torenware commented
StatusFileSize
new issue-1145374.patch696 bytes

Attaching the patch.

Torenware’s picture

Torenware commented
Status: Active » Patch (to be ported)
Newbieke’s picture

Newbieke commented
Title: Subthemes overriding color module supporting modules do not respect color settings » stupid question
Category: bug » support

how do I install patches on a hosted system. I do not have access to the server?
eg: one.com

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Title: stupid question » Subthemes overriding color module supporting modules do not respect color settings
Category: support » bug
Torenware’s picture

Torenware commented
Version: 7.0 » 7.2
Assigned: Unassigned » Torenware
Status: Patch (to be ported) » Needs review

I've just confirmed that:

1) This is still a problem in 7.2
2) The patch supplied in #1 still applies cleanly to the 7.x branch with git apply, and it still resolves the issue.

I'm not sure whose attention I need to get here, but it would be nice if somebody would look at this patch :-)

Tor Arne Thune’s picture

Tor Arne Thune commented
Version: 7.2 » 8.x-dev
Issue tags: +Needs backport to D7

Great. Let's get some eyes on this. All bug fixes must be committed to 8.x and then backported to 7.x.

Status: Needs review » Needs work

The last submitted patch, issue-1145374.patch, failed testing.

dvessel’s picture

dvessel commented

The description isn't very clear. The sub-theme does not have its own color settings or the color settings from the base theme doesn't affect the sub-theme? The expected behavior is to have an independent color setting for the sub-theme and *not* inherit the custom colors from the base theme.

tommyk’s picture

tommyk commented

subscribing

Torenware’s picture

Torenware commented
Version: 8.x-dev » 7.2
Status: Needs work » Closed (works as designed)
Issue tags: -Needs backport to D7 +stupid user tricks

It appears my bug is invalid. I looked at the failed test result, and discovered the problem:

My sub-theme's .info file references the main color CSS file as css/color.css:

name = bartik_subtheme
description = Subtheme of bartik to demonstrate #1145374
core = 7.x
engine = phptemplate
base theme = bartik
stylesheets[all][] = css/color.css

;; these must be copied over from Bartik, or
;; we get PHP errors:
regions[header] = Header
[ rest of the regions[...] omitted here... ]

This appears to cause the problem. My patch is only needed because I got the name of the spreadsheet incorrect, which should have been in the .info as

stylesheets[all][] = css/colors.css

I'm not sure if I copied over one of the "howto" examples over incorrectly, or if the example itself is wrong. If the example is wrong -- I don't remember which URL I got the demo code from -- and someone else sees this problem, they should enter the URL under this issue, so we can get the example fixed as well.

Needless to say, since it isn't broken in 7.2, it shouldn't be fixed in 8.x, since I was wrong here. Score another one for SimpleTest. I'm adding a "stupid user tricks" tag as well :-)