Please make a note on the project page that this module may/will interfere with GlobalRedirect (which makes an effort to strip trailing slashes for improved SEO).

CommentFileSizeAuthor
#5 GlobalRedirect.GIF31.23 KBAkaoni

Comments

Akaoni’s picture

Akaoni commented

Good pickup, Nicholas (and very quick too)!!
I've just installed GlobalRedirect so will test and address/note any issues.

Akaoni’s picture

Akaoni commented
Assigned: Unassigned » Akaoni
Akaoni’s picture

Akaoni commented
Status: Active » Needs review

With both Trailing Slash and GlobalRedirect > Deslash enabled, any requests to URLs with a trailing slash (eg. example.com/user/) currently redirect in an infinite loop.

This GlobalRedirect patch will fix this:
http://drupal.org/node/1130210

I've also added support to Trailing Slash for the Drupal 6.x custom_url_rewrite_outbound function.
This fixes the issue for current versions of GlobalRedirect.

This means however that when Trailing Slash is enabled, the GlobalRedirect > Deslash setting does nothing.
I'll note this on the Trailing Slash project page.
Would you also like me to add code that disables the GlobalRedirect > Deslash setting and explains why a user can't enable it?

nicholasthompson’s picture

nicholasthompson
Primary language English
commented

Hmm. You could either disable the option (ie force it) or use hook_requirements to check if it's enabled and flag a problem if it is?

Did you test against DEV or one of the "supported" tagged releases?

Akaoni’s picture

Akaoni commented
StatusFileSize
new GlobalRedirect.GIF31.23 KB

I tested against GlobalRedirect version 7.x-1.3 with and without the above mentioned patch.

I've disabled the option and provided users with an explaination message that links to the Trailing Slash config page (see attached image).

Akaoni’s picture

Akaoni commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.