Howdy,

actually the textarea revision log appears at bottom on all node types, not only ones for whose the module is activated ('create new revision in moderation').

Just wandering if is this by design, or if it could be improved somehow, making the log appear only on types with new revisions going into moderation...?

thx

Comments

toemaz’s picture

I was able to reproduce this problem. I believe this can be solved with a fix, implementing the form_alter hook.
But perhaps it would be better to look into the core for a nice solution.

toemaz’s picture

Status: Active » Needs work
StatusFileSize
new172 bytes

A quick work around without changing the revision_moderation module: add this module to your system and enable it. It will make the log window disappear.

It's of course not a nice long term solution. Perhaps a very simple one: a setting to display the log textarea or not. Or perhaps we can create a contrib module for a separte log system. Let me explain that last one.

This revision_moderation module is supposed to give users the possiblity to change the content. This change can vary: sometimes it is a minor change, sometimes a bigger change. For my type of website, it would be nice that users are able to select the type of change they made from a combo box. I know it seems strange but it some cases this might be usefull:

  • this way you can distribute the moderation based on the change
  • as you predefine some 'change types', it's possible to control the log better (no clutter)

Would this be usefull in any kind for your type of website?
Also, I must check whether there isn't already something like this on the CVS.

toemaz’s picture

StatusFileSize
new172 bytes

I forgot to attach the module. Here it is.

toemaz’s picture

Status: Needs work » Fixed

I guess we can leave it as a contrib module. No need to clutter the revision_moderation module.

webchick’s picture

hi, toemaz.

In 4.7.x, the "log" field was only added to books and pages. This is not very useful, since you basically always want the log field whenever there are revisions present, in order to track why changes were made. So that is why the module adds log fields to all node types.

In 5.x, however, log fields are now auto-appended to *all* content types when revisions are enabled (although node administrators always see the field). So this functionality would no longer be needed in a 5.x port of the module.

Hope that helps clear things up.

toemaz’s picture

Thx for the clarification!

webchick’s picture

In looking at this more closely, I see the bug the original poster was talking about... the log field shows up for all node types, regardless. It should only show up on types that have revisions enabled.

This has now been fixed in the 4.7 branch.

marcoBauli’s picture

webchick, thanks, yep that's what i meant to say (sorry for my non-motherlanguageness), great to hear is fixed now! cheers

webchick’s picture

marcob: No, your English is fine, I got distracted by the other comments. :)

No problem!

Anonymous’s picture

Status: Fixed » Closed (fixed)