$errors which is passed to _imagemagick_convert_exec by _imagemagick_check_path. If it then returns something other than 0, additional errors is attempted to be added to the $errors which causes PHP error since it no longer is an array.

Comments

googletorp’s picture

Status: Active » Needs review

I have made a patch for this and added it to my imagemagick sandbox.

Link to commit

Link to diff

sun’s picture

StatusFileSize
new5.09 KB

Yes, this badly needs some clean-up. The code dates back to some very old ages.

Can you try attached patch?

sun’s picture

Title: _imagemagick_convert_exec convert $errors into string. » _imagemagick_convert_exec() overwrites passed in $errors array with a string

Better title.

sun’s picture

StatusFileSize
new10.13 KB

Revamped.

sun’s picture

StatusFileSize
new9.57 KB

Minor adjustments.

sun’s picture

StatusFileSize
new10.08 KB

Fixed phpDoc.

Will leave this here for review for one day.

sun’s picture

Status: Needs review » Fixed

Committed to master.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.