Many other modules allow users to specify machine names for different configuration settings. I would like to propose that we do the same for fieldmaps, as "contact_fieldmap" is much more intelligible than "c4ca4238a0b923820dcc509a6f75849b".

We could also provide the option to use an md5 hash if the user doesn't specify a machine name.

What do you all think?

CommentFileSizeAuthor
#6 machine_name_support_for_fieldmap-1199124-6.patch2.91 KBkurtzhong

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

+1

Also, instead of md5 hash as the default, maybe require the "map description" field, and base the machine name on that (lowercased, spaces and special characters replaced with underscores, truncated if necessary).

EvanDonovan’s picture

EvanDonovan commented

Huge +1 for me.

All the changes currently happening in 6.x-2.x are going to have to be ported by me or others to 7.x-2.x, but I think it is worth it.

I think longwave's suggestion makes sense; that is, I think, how Feeds does it.

EvanDonovan’s picture

EvanDonovan commented
Issue tags: +D7 to backport

Already exists in 7.x-2.x. I'll need to backport the code.

kurtzhong’s picture

kurtzhong commented

Is this done already? I really need this this feature now.

kostajh’s picture

kostajh commented

@kurtzhong see comment #3. It's in 7.x-2.x but not in 6.x-2.x

kurtzhong’s picture

kurtzhong commented
StatusFileSize
new machine_name_support_for_fieldmap-1199124-6.patch2.91 KB

I made a patch for this, hope it works.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
aaronbauman’s picture

aaronbauman
he/him
commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

closing all 6.x issues