This has no business in the class's form builder:

    if (is_null($connection)) {
      $new = TRUE;
      $connection_types = clients_get_connection_types();
      drupal_set_title(t('Add @type connection', array(
        '@type' => $connection_types[$type]['label'],
      )));
    }
    else {
      $form['cid'] = array(
        '#type' => 'value',
        '#value' => $connection->cid,
      );
    }

What was I thinking??

Comments

joachim’s picture

Status: Active » Fixed

Issue #1146060 by joachim: Further fixes with add and edit form merge; moved title setting to base form.

Turned into a bit of a cleanup...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.