Secure Download

Can you post a link to your sandbox?

Changing priority according to the new priority guidelines.

These lines should be removed:

7 files[] = secure_download.install
8 files[] = secure_download.module

Now files directive is only used for additional includes that have classes.

Hook-implementing functions should always be introduced with the comment line "Implements hook..."

Check on coding standards in general.

Apologies for the ridiculous delay.

The applicant has been contacted to ask if the application is abandoned.

Great!
You have a couple of coding standards issues:
http://ventral.org/pareview/httpgitdrupalorgsandboxwienczny1146078git

In the README.txt lines should not exceeds 80 characters (that is also for comments in module files)

The second line in the file doc comment must be " * @file", like:

/**
 * @file
 * Description of what the file contains.
 */

All functions should have comments, like (dummy example):

/**
 * What this functions does.
 *
 * @param array $modulename
 *   Set ctools as the owner to the plugin
 * @param array $content_type
 *   Set the content type
 *
 * @return string
 *   Set the path to the ctools-plugin directory
 *
 */
function modulename_name($modulename, $content_type) {

Mostly of the warnings is about indenting - so is should be pretty easy ti fix.
You could do a new automatic review yourself if you reuse the url above.

If you have any questions, please ask, so hopefully the process is going to be quick.

As per the pareview output. You are working in the master branch.. You should have only a README.txt file in your master branch and work in a 7.x-1.x branch.

see documentation:

• Moving from master branch
• release naming conventions
• creating a branch in git

Review of the 7.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

Manual review:
- Should use t function with title and description for example:

  $items['admin/config/media/secure_download'] = array(
    'title' => 'Secure Download',
    'description' => 'Configuration for Secure Download module',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('secure_download_form'),
    'access arguments' => array('access administration pages'),
    'type' => MENU_NORMAL_ITEM,
  );

- Should use drupal_realpath here:

  $path = realpath(drupal_get_path('module', 'node') . '/../../') . '/' .

Still some 'dot' files in your master branch, which should be cleared out.

Otherwise, a quick scan looks good ... I don't pretend to understand how cherokee hidden downloads work, but I think it's safe to assume you do. ;)

manual review:

• project page is a bit short, see http://drupal.org/node/997024
• "'access arguments' => array('access administration pages'),": this permission is too generic, create your own.
• "strcmp($md5, $verification) != 0": why not just using $md5 != $verification ?
• secure_download_download(): are you sure that you need to call exit; and cannot use drupal_exit()?

Closing due to lack of activity. Feel free to reopen if you are still working on this application.