Block direct view

I haven't found anything to provide the functionality, especially implementing hook_url_outbound_alter(). I created the module because I couldn't figure out a way to do it without writing a module.

RE: The use of hook_node_access()

function disable_node_view_node_access($node, $op, $account) {
  if ($op == 'view') {
    // Check if user doesn't have access and we are viewing the node view alone.
    if (!user_access('access ' . $node->type . ' node view', $account) &&
        arg(0) == 'node' && arg(1) == $node->nid) {

arg(0) must be node, and arg(1) must be the node ID. The only panel it would block is the system /node/%node page, but it probably shouldn't be enabled for nodes handled by panels. FYI: I broke the if statement into two if statements to reduce overall site function calls/cpu cycles (though I am sure that choice be argued, and tested.)

Added a demo site link to the project page. Tried to keep it simple while still showing important features.

Demo site at: http://dnv.eosrei.net/

Added initial Rules module integration: Event - Node view denied to user.

After using this module on three sites, I've decided "Block direct view" is a more descriptive name than "Disable node view". I'll update the demo site tomorrow.

Hmm... I saw that project application a week or so after my submission. He beat me to posting by a few days.

Result when a "Views only" node is accessed:

• Internal Nodes - 404 Not found
• Block direct view - 301 Redirect to the correct Views URL, using GET variables and anchors.

IMO, the Block direct view result is far more useful and user friendly.

I've been working with Drupal for three years now, so I am totally aware of the issue of not duplicating functionality between modules. I was quite frustrated to see a module was posted a few days before mine with similar functionality. Considering this process is for developer review, and Internal Nodes provides none of the features I needed, I left my application as-is.

I'll contact the other developer, though I am not sure how our modules could be integrated.

I am implementing the two missing features, 404 and node status, in Block direct view.

New features:

• Added node status message and bdv-denied class for users with permission to view blocked nodes
• Streamlined hook_node_*() functions

Fixed:

• Removed AJAX Redirect URL field from settings form to remove Drupal core patch requirement.

I decided against implementing "404 File Not Found" functionality. It doesn't make sense to me. These nodes exist, but access to them is denied, therefore, they should be blocked with a 301/403 and not 404. If a good case for 404 is presented, I'll reconsider.

Ok. I would still use 403 for non-accessible nodes, but I understand your reasoning for 404. I'm sure people would rather have the choice.

... if integrated would end up with a "which way do you want to handle these nodes" type setting.

Issue is, Block direct view already has a per-node and per-content type "How do you want to handle this?" setting. Current options are Allowed, 403, and 301. It wouldn't be difficult to add a replacement node_load() function to handle 404 at the menu level.

I'm happy to leave it up to the reviewing people or those that grant git access to decide what happens.

I'd like to also, but Joachim has explained what must happen: Highlander rules apply. You and I need to decide the result; at least Sean Connery isn't chasing us with a sword. Only one of these can become an actual d.o project, but we can both be maintainers.

Reviewers: If mjpa and I combine our modules, and the result is approved, would we both gain Project create permission? IMHO, we've both put forth the required time and effort. Thanks!

Yes. I was on a two week vacation and just started a new job. I hope to have time to deal with this again next week.

Took me longer than I'd hoped to get back to this, but it is ready.

I implemented a 404 action using menu_get_item_alter() modifying the page_callback. Simpletests have been updated and all pass.

Updated demo site with new version and new name. http://bdv.eosrei.net/

I was asked to combine the projects, so I did. I added the 404 feature from Internal nodes into Block direct view. I did exactly what mjpa and I discussed doing. I don't understand how else I can the combine projects. I didn't copy the Internal nodes node_load() replacement method because it causes PHP notices on my testing/development site. Instead, I researched and implemented a method which doesn't cause any notices.

What else do you want me to do? Should I make a new project? Should I add mjpa as a maintainer to this project? I had planned to, but haven't heard back from him yet.

I've added mjpa as a maintainer to the Block direct view project.

sreynen: It was agreed that both mjpa and I would receive the promote project permission. I've shown my ability in every way requested in order to earn the permission. Yet mjpa receives the permission alone?

This module completely follows the coding standards, employs best practices, shows many examples of the module hook system, is integrated with rules, and provides significant simpletests. All the things I understood this application process is meant to test. I am disheartened by this.

Thanks a lot Tim! I really appreciate it.