Posted by kenorb on May 4, 2011 at 11:25am
4 followers
Jump to:
| Project: | Administration menu |
| Version: | 7.x-3.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | PHP 5.3 |
Issue Summary
This is predictable bug, based on syntax used in admin_menu and already reported two bugs:
#1107770: Mollom: Maximum function nesting level of '400' reached, aborting! in tests/mollom.test on line 83
#1105064: FileField: Test: Fatal error: Maximum function nesting level of '400' reached, aborting! in filefield.test with PHP 5.3
3.x and master contain following code:
<?php
call_user_func_array(array($this, 'parent::setUp'), array_merge(array('admin_menu'), $args));
?>http://drupalcode.org/project/admin_menu.git/blame/refs/heads/6.x-3.x:/t...
http://drupalcode.org/project/admin_menu.git/blame/refs/heads/master:/te...
which is nesting/crashing with PHP 5.3.
It should be replaced to:
<?php
parent::setUp($modules);
?>as 1.x has it.
or:
<?php
call_user_func_array('parent::setUp', $modules);
?>
Comments
#1
#2
#3
Thanks for reporting, reviewing, and testing! Committed http://drupal.org/commitlog/commit/2608/60f1006f20dc4d1f94259d17b375d49a...
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
#4
Keep in mind that when you do this: function setUp($modules = array()) {
that all your inherited classes also need to use setUp($module = array()) in their definition otherwise it causes strict errors on PHP 5.3...
#5
d'oh - fixed in a follow-up: http://drupalcode.org/project/admin_menu.git/commit/07be7d86c9def901c67d...
Looks like I have to find some time to fix my error reporting...
#6
Automatically closed -- issue fixed for 2 weeks with no activity.