Advagg - JSMin+ incompatibility with swftools [#1146888]

With advagg enabled, the swftools input filter fails to work. The error reported in the Chrome console isUncaught ReferenceError: swfobject is not defined

Disable advagg and it starts working again.

Comment	File	Size	Author
#24	advagg-1146888-24.patch	5.18 KB	mikeytown2
#14	advagg-1146888-14.patch	1.6 KB	mikeytown2

Comments

Comment #1

mikeytown2 commented 4 May 2011 at 15:29

just to double check, are you using HeadJS or LABjs or another JS loader script? If you are, try it with that loader disabled.

Comment #2

mrfelton commented 4 May 2011 at 15:33

I'm not using any special JS loader.

The swfobject.js isn't getting loaded onto the page. The only thing that I can see that is slightly different from standard about how this gets loaded onto the page, is that it lives in the libraries directory instead of the module directory.

This is called from within hook_init:


/**
 * Places swfobject JavaScript on the page, either using the local code, or from Google APIs.
 */
function swftools_swfobject2_add_js() {

  // Set flag to indicate if the JavaScript has been added to the header
  static $swfobject2_has_run;

  // Output JavaScript to the header to load the SWF Object code
  if (!$swfobject2_has_run) {

    // Find out if swfobject2 is available locally and add script accordingly
    if (swftools_swfobject2_available_locally()) {
      // Add the local script library when it is present
      drupal_add_js(SWFTOOLS_LIBRARIES . 'swfobject/swfobject.js');
    }
    else {
      // We have to add script directly to the head as drupal_add_js can't handle external scripts (drupal.org/node/91250)
      drupal_set_html_head('<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/swfobject/2.2/swfobject.js"></script>');
    }

    // Set flag to show script is in place
    $swfobject2_has_run = TRUE;

  }

}

Comment #4

mikeytown2 commented 4 May 2011 at 16:06

on the page that is throwing the error, add on ?advagg-debug=1 and then copy the watchdog output here in a code tag.

Comment #5

mrfelton commented 4 May 2011 at 16:14

Here ya go!

Comment #6

mrfelton commented 4 May 2011 at 16:15

Hmm. paste didn't work... http://pastebin.com/yMQqJttZ

Comment #7

izmeez commented 4 May 2011 at 16:16

subscribing

Comment #8

mikeytown2 commented 4 May 2011 at 16:33

looking at the debug ouput and all files that are in the bundles are correct. Any JS files give you a 404? What happens when you do ?advagg=0

Can I get the line number and filename of where the JS error occurs? Also the file's contents of js_97af7b6ad5c97f4044190eebaaeff1d0_0.js and the file where the error is thrown.

Comment #9

mrfelton commented 4 May 2011 at 16:42

No JS files give a 404.

With ?advagg=0 swfobject.js is loaded onto the page and there are no errors.

With advagg=1, swfobject.js is not included in any of the bundles, and the js error comes from within the node body, since swfobject is called via swftools's input format (by entering [swf file=path/to/file] in the node body.

Comment #10

mrfelton commented 4 May 2011 at 16:46

This is the content of the js bundle which is supposed to contain swfobject.js: http://pastebin.com/aW2bu4nS. It's clearly not in there.

Comment #11

mrfelton commented 4 May 2011 at 17:20

Tacked the problem down to this line...


      // Invoke hook_advagg_js_alter() or hook_advagg_css_alter to give
      // installed modules a chance to modify the data in the bundle if
      // necessary.
      drupal_alter('advagg_' . $type, $data, $files, $bundle_md5);

Comment #12

mrfelton commented 4 May 2011 at 17:28

Disabling the advagg_js_compress module resolves the issue.

Comment #13

mikeytown2 commented 4 May 2011 at 18:00

Title:	Advagg incompatibility with swftools	» Advagg - JSMin+ incompatibility with swftools
Component:	Code	» JS Compression

I'll need to add in smarter checks for the JSMin+ code. Sounds like after it got compressed it returned an empty string.

Comment #14

mikeytown2 commented 4 May 2011 at 18:11

Status:

Active

» Needs review

Status	File	Size
new	advagg-1146888-14.patch	1.6 KB

mind testing this patch?

Comment #15

mrfelton commented 4 May 2011 at 18:50

Yeah, that seems to do it :)

Comment #16

mikeytown2 commented 4 May 2011 at 18:52

Status:

Needs review

» Fixed

Thanks for testing!
committed http://drupalcode.org/project/advagg.git/commit/b2e8916

Comment #17

mrfelton commented 4 May 2011 at 19:04

Thanks for fixing!!

Comment #18

mrfelton commented 13 May 2011 at 15:17

Status:

Fixed

» Active

I'm running into this issue again with the latest -dev snapshot. Odd thing is, it's only an issue in Internet Explorer. Works fine in Chrome

Comment #19

mikeytown2 commented 13 May 2011 at 18:18

What version of IE? Are you using CSS Embedded Images? IE released a breaking update if your using that module. Do you get a line number error from the JS? If Yes, Any chance you could attach the file that its bombing on and paste the error from IE.

Comment #20

mrfelton commented 13 May 2011 at 21:14

This is a problem in IE 7 and 8.

I'm not using CSS Embedded Images.

There is no specific JavaScript error being reported by IE, but SWFTools fails to load the Flash file onto the page as it says that flash components can not be found. This is the exact same symptom as before when SWFObject was not getting included into the JS, although this time, it does look as if the swfobject.js code is included in the minified javascript.

Disabling advagg gets everything working again. So does switching from the swfobject embedding method to direct embedding - presumably because it's not relying on the swfobject.js to do the embedding.

Comment #21

mikeytown2 commented 13 May 2011 at 22:32

Try upgrading to the lastest version of the swftools library
http://drupal.org/node/303203

If you turn off JS compression does the problem go away? After disabling the module be sure to go to admin/settings/advagg/config and do either a Cache Rebuild OR Forced Cache Rebuild OR a Master Reset so that the compressed JS will no longer be accessed.

Are you using LABjs Or HeadJS? If yes, disable them and see if the error goes away.

Comment #22

mikeytown2 commented 20 May 2011 at 20:01

Status:

Active

» Postponed (maintainer needs more info)

Need to know if the latest SWFTools library fixes this issue.

Comment #23

mrfelton commented 26 May 2011 at 19:04

Status:

Postponed (maintainer needs more info)

» Active

Sorry, no joy...

I still have this problem with the latest swftools and the latest advagg module.

Same problem with javascript compression disabled too.

Flushing caches at /admin_menu/flush-cache/advagg makes no difference.

I'm not using HeadJS or LABjs.

Comment #24

mikeytown2 commented 28 May 2011 at 00:45

Component:	JS Compression	» JS CDN
Status:	Active	» Fixed

Status	File	Size
new	advagg-1146888-24.patch	5.18 KB

Going to make an option to get the SWFTools library from Google's CDN in the JS CDN module.

Patch has been committed, let me know if it doesn't fix the issue.

Comment #25

11 June 2011 at 00:51

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Advagg - JSMin+ incompatibility with swftools

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

News items

Our community

Documentation

Drupal code base

Governance of community