I seem to spend most of my time hacking modules to provide path alias support these days. This is one I feel confident to submit as a patch, the module is very nicely coded and easy(ish) to understand. The patch adds a new admin option to enable the use of aliases as opposed to 'taxonomy/term/xx'

CommentFileSizeAuthor
#1 tagadelic_pathalias_patch_0.txt1.31 KBAstralP
tagadelic_pathalias_patch.txt1.31 KBAstralP

Comments

AstralP’s picture

AstralP commented
StatusFileSize
new tagadelic_pathalias_patch_0.txt1.31 KB

Updated patch, forgot to send the default value to variable_get() which caused a watchdog error.

AstralP’s picture

AstralP commented

Does no-one else think this is valid? I think it's essential for avoiding duplicate content on search engines.

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs review » Needs work

I don't understand your need. l() has checks for pathaliases built in. So I think there is something wrong with your installation.

That said, your code style needs attention. We don't put } else { on one line. Also mind the spacing in if. And last: try to avoid weird logic as 'variable_get('tagadelic_alias','off')=='on'' this is confusing, please use normal BOOLS there.

The most important matter, is that this should not be an option. we should just choose The One Way, and built that in, options wether or not links should be aliases are pure clutter. They should be aliases. Always.

But again: They /are/ aliases. so please check what is amiss here.

AstralP’s picture

AstralP commented
Status: Needs work » Closed (fixed)

Hi Bèr

Thanks for letting me know, I removed the code and you are correct it works fine. The installation I was working on previously was an upgrade from 4.6 to 5 and there were quite a few problems which led me to scrap it and rebuild from a fresh 5 install. I hacked this code on that installation which must have been the cause. I will have to look at the other modules I changed also as maybe they are also ok, I wondered why I was the only person bothered by this...