We would be using a more standard Drupal pattern if we renamed this hook.

Also, such a renaming will potentially avoid fatal error when combined with existing beta5 integrations.

CommentFileSizeAuthor
#6 1146976-6.patch2.23 KBpwolanin
#5 1146976-more-cleanup.patch2.65 KBpwolanin
#1 1146976-1.patch9 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 1146976-1.patch9 KB
scor’s picture

scor commented
Title: Rename hook_apachesolr_modify_query to hook_apachesolr_query_alter » Rename hook_apachesolr_modify_query to hook_apachesolr_query_alter and other API clean up

+1

haven't tried the patch but it looks good.

+++ b/apachesolr.api.php
@@ -5,29 +5,29 @@
-  $query->add_filter("is_uid", 1);
+  $query->addFilter("is_uid", 1);
 
   // Only search titles.
-  $query->params['qf'] = array('label');
+  $query->replaceParam('qf', 'label');

+++ b/apachesolr.api.php
@@ -5,29 +5,29 @@
-  $query->set_available_sort('entity_id', array(
+  $query->setAvailableSort('entity_id', array(

I guess these are just some documentation cleanup (e.g. patch has been committed in a separate issue)?

pwolanin’s picture

pwolanin commented

yes, doc cleanup - see the query class.

pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

committing

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1146976-more-cleanup.patch2.65 KB

also committed this

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1146976-6.patch2.23 KB

committing this cleanup-up patch too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.