"post with no akismet checking" perm doesn't seem to work

ZoeN - January 31, 2007 - 19:22
Project:Akismet
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

I've given this permission (using admin/access) to two of the roles on my site, but some posts by users with these roles are still being marked as spam by akismet.

#1

evanssd - February 14, 2007 - 17:32

me too, anybody?

#2

furmans - March 8, 2007 - 04:10

Yes. I've seen this too.

#3

greg_y - March 19, 2007 - 18:23

another one ... have double checked the contributor's access control level and have unset and reset the "post with no akismet checking" setting. Contributors still get caught by Akismet.

#4

SimonVlc - May 8, 2007 - 23:38

Same here... drupal v5.1.

#5

tangent - August 1, 2007 - 20:36
Version:4.7.x-1.1-2» 5.x-1.x-dev
Status:active» needs review

I've run into this as well. It seems that the 'post with no akismet checking' permission is not even used in the module. I've created a patch which places the permission check in the appropriate place.

Oddly, there is still a call to a Drupal 4.x function node_get_name() which I started have problems with after applying this change. The patch also changes this to use $node->type.

AttachmentSize
akismet.module.patch 2.8 KB

#6

Gregory Go - September 6, 2007 - 04:17

+1
works for me

#7

tangent - September 11, 2007 - 20:18
Status:needs review» reviewed & tested by the community

We'll consider it reviewed then.

#8

ikke - September 24, 2007 - 17:50

Hm - in backend and the akismet-module the entrys are shown as unpublished but I can see them at the website :-(

#9

ikke - September 24, 2007 - 19:10

Sorry - forget my entry. it was a problem with Views. The patch works.

#10

avskip - September 26, 2007 - 22:59
Version:5.x-1.x-dev» 4.7.x-1.1-2

Not using the patch, but I'm using the 4.7 variant of this and it seems to ignore the "No Akismet Checking" permission I have set for some of the users.

#11

avskip - September 26, 2007 - 23:17

How does one apply the above patch to Version AKISMET_MODULE_VERSION', '1.1.2' ???

I tried "patch -b akismet.module < akismet.module.patch and it failed something about a second "hunk"?

I've never done this before...

#12

Gregory Go - October 19, 2007 - 07:31

@avskip - if the output doesn't say "failed" anywhere, then you're fine. This was my output for patching akismet-5.x-1.3 (aka version 1.2 in the akismet.info file)

[~/drupal/drupal-5.3/modules/akismet] patch < akismet.module.patch
patching file akismet.module
Hunk #1 succeeded at 356 (offset -22 lines).

#13

avskip - October 24, 2007 - 22:47

I think the problem I'm having is that the patch on here is for the 5.x version and I'm using thre 4.7 version.

#14

avskip - November 6, 2007 - 19:21
Version:4.7.x-1.1-2» 5.x-1.3
Priority:normal» critical

I recently upgraded my site to Drupal 5.3 and installed the Akismet module for Drupal 5. I then installed the patch from above (with no errors). It is still ignoring the NoAkismet Checking Perm that I have set for specific people.

Any ideas?

#15

jant - November 9, 2007 - 23:33

Same for me. Patching went without any error, but issue still exists. I'm on Drupal 5.1 and using Akismet 5.x-1.3.

#16

jant - November 13, 2007 - 11:01
Status:reviewed & tested by the community» needs review

#17

avskip - January 16, 2008 - 17:15

I've upgraded to Drupal 5.5 and still have the patched code (#5) in the Akismet module. It's definitely ignoring the "No Akismet Check" perm.

Any ideas on a fix on this one?

#18

pwhite - February 25, 2008 - 21:27

I've got this problem as well - any ideas when the fix will make it into a release?

#19

drewish - March 18, 2008 - 23:04
Status:needs review» needs work

#5 doesn't apply any more. anyone want to re-roll it?

#20

frjo - July 13, 2008 - 07:29
Version:5.x-1.3» 5.x-1.4

Here is a updated patch for version 1.4.

AttachmentSize
post_with_no_akismet_checking.patch 847 bytes

#21

drewish - July 13, 2008 - 07:45
Status:needs work» fixed

committed to HEAD and DRUPAL-5.

#22

Anonymous (not verified) - July 31, 2008 - 04:46
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#23

avskip - September 5, 2008 - 15:43
Version:5.x-1.4» 5.x-1.x-dev

I am using the 5.x-1.x-dev version dated 2008-Jul-13 and the "post with no akismet checking" perm is not working. I have one subscriber with the perm set that has every post tagged as spam when it shouldn't even be checked to be spam.

I'm on Drupal 5.10

Any ideas?

 
 

Drupal is a registered trademark of Dries Buytaert.