The helper function getFormat in ajax_markup.js relies on looking for the checked format in the Input Filter field set. This doesn't exist if better_formats has been configured not to display it.

I'm using ajax_markup with BUEditor to provide preview functionality - very good when it worked before I configured better_formats. BUEditor will be used for forum posts and comments.

I'm not sure whether there's any easy way for ajax_markup to work out which format is to be applied to a particular textarea for a particular node/comment type for a particular user, which is the level of granularity that better_formats provides.

There's nothing in my HTML that indicates the format to be used - no class or id on the textarea for example. Perhaps better_formats could be changed to provide the missing information.

For the meantime, I'm just going to changed the defaults formats used in the above javascript helper function to match the single formats I'll be allowing for forum posts and comments. I won't be using BUEditor's preview function anywhere else, so this should resolve the issue for me. Naturally hard-coding the formats isn't ideal and won't suit everybody!

CommentFileSizeAuthor
#2 ajax_markup.better_formats.patch707 bytesufku

Comments

dunx’s picture

dunx commented

Raised twin issue with better_formats.

http://drupal.org/node/1148488

ufku’s picture

ufku commented
Title: Not compatible with better_formats - can't determine format » Support for better_formats defaults
Version: 6.x-1.0 » 6.x-1.x-dev
Category: bug » feature
Status: Active » Needs review
StatusFileSize
new ajax_markup.better_formats.patch707 bytes

Here is patch that checks better-formats' default "node" format when the supplied format is set to site-default(0).

Note that it will use the node default even if the textarea is part of another site element such as a block or comment.

dunx’s picture

dunx commented

That always returns 1. The format filter of the node type I'm editing would always be 3.

I had a quick look at the better_formats code, but couldn't spot anything obvious.

dunx’s picture

dunx commented

See discussion here:
http://drupal.org/node/1148488

Maintainer is saying there's no better_formats function that can be used to determine the format when no filter field set is displayed, but that this can also happen in core when there's only one filter available in any given case. Not sure if there's a core function that can resolve the current issue.

For the moment, AM will not work if there is no filter field set, so it needs some way of determining what the single filter is for the current node type/user combo.

For the moment, I'm just going to leave my formats hard-coded in the .js file, but good luck with finding a proper solution.

dunx’s picture

dunx commented

Just a follow up to say this is still an issue. For the record my "forum replies" use format number 3, so in ajax_markup.js I just hardcode the following function to return 3!

//Helper function to find the input format of a given textarea. defaults to 0 when there is no format.
$.ajaxMarkup.getFormat = function(selector) {
  // See http://drupal.org/node/1147462
  return 3;

  var T = $(selector)[0];
  if (!T || T.tagName != 'TEXTAREA') {
    return 0;
  }
  var i, format = 0, name = T.name || '';
  if (name == 'body' || name == 'teaser_js' || name == 'comment') {//node body, teaser and comment fields
    format = $('input[name=format]:checked', T.form).val() || 0;
  }
  else if ((i = name.indexOf('[value]')) > 0) {//cck fields
    format = $('input[name="'+ name.substring(0, i) +'[format]"]:checked', T.form).val() || 0;
  }
  return format;
};