See #1027786: Remove soft-dependency on Block module

We should get rid of hook_init and add the appropriate css and js as needed, including creating a separate .admin.js for the report page.

CommentFileSizeAuthor
#5 feedback.assets.5.patch2.51 KBsun
#4 1147476.patch2.43 KBjody lynn
#3 1147476.patch1.85 KBjody lynn

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Very good idea :)

Only possible in D7, since D6 does not allow to add JS/CSS to the page at the time the feedback widget is rendered.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

oh, that said, I'd love to additionally separate the non-admin CSS into feedback.base.css and feedback.theme.css, following core's lead on proper separation of logic/functionality and visual styling.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
Assigned: jody lynn » Unassigned
Status: Active » Needs review
StatusFileSize
new 1147476.patch1.85 KB

There actually wasn't any css other than for the feedback form itself, so I just split up the js.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented
StatusFileSize
new 1147476.patch2.43 KB

Correct patch

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed
StatusFileSize
new feedback.assets.5.patch2.51 KB

Committed with slight adjustments — whenever possible, use #attached instead.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.