Posted by Jody Lynn on May 5, 2011 at 12:06am
2 followers
| Project: | Feedback |
| Version: | 7.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
See #1027786: Remove soft-dependency on Block module
We should get rid of hook_init and add the appropriate css and js as needed, including creating a separate .admin.js for the report page.
Comments
#1
Very good idea :)
Only possible in D7, since D6 does not allow to add JS/CSS to the page at the time the feedback widget is rendered.
#2
oh, that said, I'd love to additionally separate the non-admin CSS into feedback.base.css and feedback.theme.css, following core's lead on proper separation of logic/functionality and visual styling.
#3
There actually wasn't any css other than for the feedback form itself, so I just split up the js.
#4
Correct patch