Needs review
Project:
Webtrends
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
5 May 2011 at 11:35 UTC
Updated:
16 Apr 2013 at 16:00 UTC
Jump to comment: Most recent file
Is there a plan for a Drupal 7 version of this module?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | webtrends-d7-1147900-6.patch | 10.5 KB | ronan |
| #2 | webtrends-d7-version-1147900-1.patch | 11.24 KB | andyzhang |
Comments
Comment #1
tudor.sitaru commentedYes, a Drupal 7 version is coming this week.
Comment #2
andyzhang commentedUpdated to support D7. Updated webtrends.js to the version 9.4.0.
As D7 doesn't have hook_footer, replaced it with hook_page_alter, and also added webtrends.install file to remove module variables during uninstall.
Comment #3
jerdavisAny word on getting this vetted and added to the d7 branch?
Comment #4
ramlev commentedWhen testing the patch in version 7.x-1.x-dev it cannot patch.
output from terminal
==================
$ git apply webtrends-d7-version-1147900-1.patch
webtrends-d7-version-1147900-1.patch:20: trailing whitespace.
// Version: 9.4.0
webtrends-d7-version-1147900-1.patch:122: trailing whitespace.
try{
webtrends-d7-version-1147900-1.patch:164: trailing whitespace.
}
error: patch failed: webtrends.info:3
error: webtrends.info: patch does not apply
==================
When cloning 7.x-1.x-dev from git.drupal.org then i can path the files, but with some warnings about trailing whitespaces.
output from terminal
==================
$ git apply webtrends-d7-version-1147900-1.patch
webtrends-d7-version-1147900-1.patch:20: trailing whitespace.
// Version: 9.4.0
webtrends-d7-version-1147900-1.patch:122: trailing whitespace.
try{
webtrends-d7-version-1147900-1.patch:164: trailing whitespace.
}
webtrends-d7-version-1147900-1.patch:251: new blank line at EOF.
+
warning: 4 lines add whitespace errors.
==================
Comment #5
mgiffordThere is a dev release, shouldn't this be closed?
Comment #6
ronan commentedThis applies cleanly to the 7.x dev branch for me but it still gives the settings a d6 path. This version moves the settings to config > system.