Captcha not properly saving a correct answer in $_SESSION (fixed version) [#114835]

I think that there is an error in captcha.module validation function.
Even when a math answer is correct it comes with an error message.
Captcha seem to return an empty value.
I modified captcha.module as below and it works fine for me.

/**
* Default implementation of the captcha validation function.
*/

function captcha_captchavalidate(&$captcha_word, &$correct) {
$captcha_word = drupal_strtolower($captcha_word);M

if (($_SESSION['captcha'] != '') AND ($captcha_word == $_SESSION['captcha'])) {
$correct = TRUE;
}elseif (($_SESSION['captcha'] != '') AND ($captcha_word != $_SESSION['captcha'])) {
$correct = FALSE;
form_set_error('captcha_response', t('The answer you entered to the math problem is incorrect.'));

}
}

Comment	File	Size	Author
#2	captcha_fix_validate.patch	1.14 KB	dalin
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

desrod CreditAttribution: desrod commented 5 February 2007 at 21:16

A unified diff against the latest released captcha module would be best... can you repost with a diff?

Comment #2

dalin

he/him

English

🇲🇽, 🇨🇦, 🌍

CreditAttribution: dalin commented 8 February 2007 at 22:37

Assigned:	Unassigned	» dalin
Priority:	Normal	» Critical
Status:	Active	» Needs review

File	Size
captcha_fix_validate.patch	1.14 KB

I don't think you're poking in the right place. From what I can see, your suggested change would also add a vulnerability.

Here is a patch that I think solves the problem. It also incorporates the fix listed in 114387.

I am patching against the 4-7 version, but it should also apply to the 5 branch.

Comment #3

dalin

he/him

English

🇲🇽, 🇨🇦, 🌍

CreditAttribution: dalin commented 8 February 2007 at 22:40

Title:

Captcha 5.x.1.1 my captcha.module modification

» Captcha not properly saving a correct answer in $_SESSION

Comment #4

ahmaddani CreditAttribution: ahmaddani commented 11 March 2007 at 17:30

Title:	Captcha not properly saving a correct answer in $_SESSION	» Captcha not properly saving a correct answer in $_SESSION (fixed version)
Version:	5.x-1.1	» 4.7.x-1.2

Please make fixed version for this module. Why new comer like me, must install bug version?

Thanks before..

ahmaddani
http://ahmad.indieoffset.com